Herbert Xu wrote:
> You don't need to disable BH in netif_poll since it's always called
> with BH disabled.
>
Ah, yes, you mentioned that before. I'll fix it up.
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More
Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:
>
> @@ -1212,10 +1212,10 @@ static int netif_poll(struct net_device
>int pages_flipped = 0;
>int err;
>
> - spin_lock(>rx_lock);
> + spin_lock_bh(>rx_lock);
>
>if (unlikely(!netfront_carrier_ok(np))) {
> -
netfront contains two locking problems found by lockdep:
1. rx_lock is a normal spinlock, and tx_lock is an irq spinlock. This
means that in normal use, tx_lock may be taken by an interrupt routine
while rx_lock is held. However, netif_disconnect_backend takes them
in the order
netfront contains two locking problems found by lockdep:
1. rx_lock is a normal spinlock, and tx_lock is an irq spinlock. This
means that in normal use, tx_lock may be taken by an interrupt routine
while rx_lock is held. However, netif_disconnect_backend takes them
in the order
Jeremy Fitzhardinge [EMAIL PROTECTED] wrote:
@@ -1212,10 +1212,10 @@ static int netif_poll(struct net_device
int pages_flipped = 0;
int err;
- spin_lock(np-rx_lock);
+ spin_lock_bh(np-rx_lock);
if (unlikely(!netfront_carrier_ok(np))) {
-
Herbert Xu wrote:
You don't need to disable BH in netif_poll since it's always called
with BH disabled.
Ah, yes, you mentioned that before. I'll fix it up.
J
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
6 matches
Mail list logo
