Re: [PATCH 23/28] perf tools: Factor out hist_entry_iter code

2014-01-13 Thread Namhyung Kim
On Sat, 11 Jan 2014 17:24:08 +0100, Jiri Olsa wrote: > On Wed, Jan 08, 2014 at 05:46:28PM +0900, Namhyung Kim wrote: >> Now the hist_entry_iter code will be shared with perf top code base. >> So move it to util/hist.c and do some necessary cleanups and renames. > > factoring code from this very

Re: [PATCH 23/28] perf tools: Factor out hist_entry_iter code

2014-01-13 Thread Namhyung Kim
On Sat, 11 Jan 2014 17:24:08 +0100, Jiri Olsa wrote: On Wed, Jan 08, 2014 at 05:46:28PM +0900, Namhyung Kim wrote: Now the hist_entry_iter code will be shared with perf top code base. So move it to util/hist.c and do some necessary cleanups and renames. factoring code from this very

Re: [PATCH 23/28] perf tools: Factor out hist_entry_iter code

2014-01-11 Thread Jiri Olsa
On Wed, Jan 08, 2014 at 05:46:28PM +0900, Namhyung Kim wrote: > Now the hist_entry_iter code will be shared with perf top code base. > So move it to util/hist.c and do some necessary cleanups and renames. factoring code from this very patchset.. looks like it could be easily squashed with: perf

Re: [PATCH 23/28] perf tools: Factor out hist_entry_iter code

2014-01-11 Thread Jiri Olsa
On Wed, Jan 08, 2014 at 05:46:28PM +0900, Namhyung Kim wrote: Now the hist_entry_iter code will be shared with perf top code base. So move it to util/hist.c and do some necessary cleanups and renames. factoring code from this very patchset.. looks like it could be easily squashed with: perf

[PATCH 23/28] perf tools: Factor out hist_entry_iter code

2014-01-08 Thread Namhyung Kim
Now the hist_entry_iter code will be shared with perf top code base. So move it to util/hist.c and do some necessary cleanups and renames. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/builtin-report.c | 468 +---

[PATCH 23/28] perf tools: Factor out hist_entry_iter code

2014-01-08 Thread Namhyung Kim
Now the hist_entry_iter code will be shared with perf top code base. So move it to util/hist.c and do some necessary cleanups and renames. Cc: Arun Sharma asha...@fb.com Cc: Frederic Weisbecker fweis...@gmail.com Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/perf/builtin-report.c |