Re: [PATCH 24/33] perf, tools: Move parse_events error printing to parse_events_options

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 01:30:06PM -0700, Andi Kleen wrote: > From: Andi Kleen > > The callers of parse_events usually have their own error handling. > Move the fprintf for a bad event to parse_events_options, which > is the only one who should need it. > > Signed-off-by: Andi Kleen > --- >

Re: [PATCH 24/33] perf, tools: Move parse_events error printing to parse_events_options

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 01:30:06PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com The callers of parse_events usually have their own error handling. Move the fprintf for a bad event to parse_events_options, which is the only one who should need it. Signed-off-by: Andi

[PATCH 24/33] perf, tools: Move parse_events error printing to parse_events_options

2012-10-26 Thread Andi Kleen
From: Andi Kleen The callers of parse_events usually have their own error handling. Move the fprintf for a bad event to parse_events_options, which is the only one who should need it. Signed-off-by: Andi Kleen --- tools/perf/util/parse-events.c | 10 +++--- 1 files changed, 7

[PATCH 24/33] perf, tools: Move parse_events error printing to parse_events_options

2012-10-26 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com The callers of parse_events usually have their own error handling. Move the fprintf for a bad event to parse_events_options, which is the only one who should need it. Signed-off-by: Andi Kleen a...@linux.intel.com --- tools/perf/util/parse-events.c | 10