Re: [PATCH 25/33] perf, tools: Support events with - in the name

2012-10-27 Thread Jiri Olsa 
On Fri, Oct 26, 2012 at 01:30:07PM -0700, Andi Kleen wrote:
> From: Andi Kleen 
> 
> - looks nicer than _, so allow - in the event names. Used for various
> of the arch perfmon and Haswell events.
> 
> Signed-off-by: Andi Kleen 
> ---
>  tools/perf/util/parse-events.l |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index c87efc1..ef602f0 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -80,7 +80,7 @@ event   [^,{}/]+
>  num_dec  [0-9]+
>  num_hex  0x[a-fA-F0-9]+
>  num_raw_hex  [a-fA-F0-9]+
> -name [a-zA-Z_*?][a-zA-Z0-9_*?]*
> +name [a-zA-Z_*?][a-zA-Z0-9\-_*?]*

this breaks cache events parsing since they are '-' separated
and having '-' in 'name' patern will endup with PE_NAME
being matched instead of  PE_NAME_CACHE_* terms

I guess you want '-' being used within 'cpu/..t=v../' terms right?
That could be done via start conditions '%x'

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 25/33] perf, tools: Support events with - in the name

2012-10-27 Thread Jiri Olsa 
On Fri, Oct 26, 2012 at 01:30:07PM -0700, Andi Kleen wrote:
 From: Andi Kleen a...@linux.intel.com
 
 - looks nicer than _, so allow - in the event names. Used for various
 of the arch perfmon and Haswell events.
 
 Signed-off-by: Andi Kleen a...@linux.intel.com
 ---
  tools/perf/util/parse-events.l |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
 index c87efc1..ef602f0 100644
 --- a/tools/perf/util/parse-events.l
 +++ b/tools/perf/util/parse-events.l
 @@ -80,7 +80,7 @@ event   [^,{}/]+
  num_dec  [0-9]+
  num_hex  0x[a-fA-F0-9]+
  num_raw_hex  [a-fA-F0-9]+
 -name [a-zA-Z_*?][a-zA-Z0-9_*?]*
 +name [a-zA-Z_*?][a-zA-Z0-9\-_*?]*

this breaks cache events parsing since they are '-' separated
and having '-' in 'name' patern will endup with PE_NAME
being matched instead of  PE_NAME_CACHE_* terms

I guess you want '-' being used within 'cpu/..t=v../' terms right?
That could be done via start conditions '%x'

jirka
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 25/33] perf, tools: Support events with - in the name

2012-10-26 Thread Andi Kleen 
From: Andi Kleen 

- looks nicer than _, so allow - in the event names. Used for various
of the arch perfmon and Haswell events.

Signed-off-by: Andi Kleen 
---
 tools/perf/util/parse-events.l |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
index c87efc1..ef602f0 100644
--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -80,7 +80,7 @@ event [^,{}/]+
 num_dec[0-9]+
 num_hex0x[a-fA-F0-9]+
 num_raw_hex[a-fA-F0-9]+
-name   [a-zA-Z_*?][a-zA-Z0-9_*?]*
+name   [a-zA-Z_*?][a-zA-Z0-9\-_*?]*
 modifier_event [ukhpGH]{1,8}
 modifier_bp[rwx]{1,3}
 
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 25/33] perf, tools: Support events with - in the name

2012-10-26 Thread Andi Kleen 
From: Andi Kleen a...@linux.intel.com

- looks nicer than _, so allow - in the event names. Used for various
of the arch perfmon and Haswell events.

Signed-off-by: Andi Kleen a...@linux.intel.com
---
 tools/perf/util/parse-events.l |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
index c87efc1..ef602f0 100644
--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -80,7 +80,7 @@ event [^,{}/]+
 num_dec[0-9]+
 num_hex0x[a-fA-F0-9]+
 num_raw_hex[a-fA-F0-9]+
-name   [a-zA-Z_*?][a-zA-Z0-9_*?]*
+name   [a-zA-Z_*?][a-zA-Z0-9\-_*?]*
 modifier_event [ukhpGH]{1,8}
 modifier_bp[rwx]{1,3}
 
-- 
1.7.7.6

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/