Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-10 Thread Kiyoshi Ueda
Hi Boaz, On Sun, 09 Dec 2007 11:43:31 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > >>> Index: 2.6.24-rc3-mm2/drivers/scsi/scsi_lib.c > > >> No I don't like it. The only client left for blk_end_request_callback() > >> is bidi, > > > > ide-cd (cdrom_newpc_intr) is another client. > > So I

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-10 Thread Kiyoshi Ueda
Hi Boaz, On Sun, 09 Dec 2007 11:43:31 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: Index: 2.6.24-rc3-mm2/drivers/scsi/scsi_lib.c snip No I don't like it. The only client left for blk_end_request_callback() is bidi, ide-cd (cdrom_newpc_intr) is another client. So I can't drop

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-09 Thread Boaz Harrosh
On Thu, Dec 06 2007 at 21:44 +0200, Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > Hi Boaz, Jens, > > On Thu, 06 Dec 2007 11:24:44 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: >>> Index: 2.6.24-rc3-mm2/drivers/scsi/scsi_lib.c >> No I don't like it. The only client left for

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-09 Thread Boaz Harrosh
On Thu, Dec 06 2007 at 21:44 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: Hi Boaz, Jens, On Thu, 06 Dec 2007 11:24:44 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: Index: 2.6.24-rc3-mm2/drivers/scsi/scsi_lib.c snip No I don't like it. The only client left for blk_end_request_callback() is

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-06 Thread Kiyoshi Ueda
Hi Boaz, Jens, On Thu, 06 Dec 2007 11:24:44 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > > Index: 2.6.24-rc3-mm2/drivers/scsi/scsi_lib.c > > === > > --- 2.6.24-rc3-mm2.orig/drivers/scsi/scsi_lib.c > > +++

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-06 Thread Boaz Harrosh
data_len; > > req->data_len = scsi_out(cmd)->resid; > req->next_rq->data_len = scsi_in(cmd)->resid; > > /* Complete only DATA of next_rq using _callback and dummy function */ > if (!blk_end_request_callback(req->next_rq, 1, next_dlen, du

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-06 Thread Boaz Harrosh
in it. Below is the patch, which updated only descriptions and comments. If you still have some concerns on this, please let me know. Subject: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3) This patch converts bidi of scsi mid-layer to use blk_end_request interfaces

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-06 Thread Kiyoshi Ueda
Hi Boaz, Jens, On Thu, 06 Dec 2007 11:24:44 +0200, Boaz Harrosh [EMAIL PROTECTED] wrote: Index: 2.6.24-rc3-mm2/drivers/scsi/scsi_lib.c === --- 2.6.24-rc3-mm2.orig/drivers/scsi/scsi_lib.c +++

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-05 Thread Kiyoshi Ueda
d dummy function */ if (!blk_end_request_callback(req->next_rq, 1, next_dlen, dummy_cb)) BUG(); if (blk_end_request(req, 1, dlen)) BUG(); scsi_release_buffers(cmd); scsi_next_command(cmd); } ---------------

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-05 Thread Kiyoshi Ueda
and comments. If you still have some concerns on this, please let me know. Subject: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3) This patch converts bidi of scsi mid-layer to use blk_end_request interfaces. rq-next_rq represents a pair of bidi requests. (There are no other

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-04 Thread Boaz Harrosh
On Sat, Dec 01 2007 at 1:35 +0200, Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > This patch converts bidi of scsi mid-layer to use blk_end_request(). > > rq->next_rq represents a pair of bidi requests. > (There are no other use of 'next_rq' of struct request.) > For both requests in the pair,

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-04 Thread Boaz Harrosh
On Sat, Dec 01 2007 at 1:35 +0200, Kiyoshi Ueda [EMAIL PROTECTED] wrote: This patch converts bidi of scsi mid-layer to use blk_end_request(). rq-next_rq represents a pair of bidi requests. (There are no other use of 'next_rq' of struct request.) For both requests in the pair,

[PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts bidi of scsi mid-layer to use blk_end_request(). rq->next_rq represents a pair of bidi requests. (There are no other use of 'next_rq' of struct request.) For both requests in the pair, end_that_request_chunk() should be called before end_that_request_last() is called for one

[PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts bidi of scsi mid-layer to use blk_end_request(). rq-next_rq represents a pair of bidi requests. (There are no other use of 'next_rq' of struct request.) For both requests in the pair, end_that_request_chunk() should be called before end_that_request_last() is called for one of