Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Doug Anderson
Tushar, On Mon, Jun 16, 2014 at 8:36 PM, Tushar Behera wrote: > On Mon, Jun 16, 2014 at 10:19 PM, Doug Anderson wrote: >> Tushar, >> >> On Mon, Jun 16, 2014 at 4:19 AM, Tushar Behera wrote: >>> On 06/13/2014 10:33 PM, Doug Anderson wrote: Tushar, On Tue, Jun 10, 2014 at 10:32

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On Mon, Jun 16, 2014 at 10:32 PM, Doug Anderson wrote: > Mark, > > On Mon, Jun 16, 2014 at 9:51 AM, Mark Brown wrote: >> On Mon, Jun 16, 2014 at 09:49:26AM -0700, Doug Anderson wrote: >> >>> Yes please. I think there's supposed to be some official ordering of >>> things. If anyone reading this

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On Mon, Jun 16, 2014 at 10:19 PM, Doug Anderson wrote: > Tushar, > > On Mon, Jun 16, 2014 at 4:19 AM, Tushar Behera wrote: >> On 06/13/2014 10:33 PM, Doug Anderson wrote: >>> Tushar, >>> >>> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera >>> wrote: Peach-pi board has MAX98090 audio codec

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Doug Anderson
Mark, On Mon, Jun 16, 2014 at 9:51 AM, Mark Brown wrote: > On Mon, Jun 16, 2014 at 09:49:26AM -0700, Doug Anderson wrote: > >> Yes please. I think there's supposed to be some official ordering of >> things. If anyone reading this has a pointer to the official sort >> order of things in the

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Mark Brown
On Mon, Jun 16, 2014 at 09:49:26AM -0700, Doug Anderson wrote: > Yes please. I think there's supposed to be some official ordering of > things. If anyone reading this has a pointer to the official sort > order of things in the device tree I'd love to see it! ;) Most exact first I believe?

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Doug Anderson
Tushar, On Mon, Jun 16, 2014 at 4:19 AM, Tushar Behera wrote: > On 06/13/2014 10:33 PM, Doug Anderson wrote: >> Tushar, >> >> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: >>> Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. >> >> If you want to be a stickler about it,

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On 06/13/2014 10:33 PM, Doug Anderson wrote: > Tushar, > > On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: >> Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. > > If you want to be a stickler about it, peach-pi actually has a > max98091. That requires code changes to

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On 06/13/2014 10:33 PM, Doug Anderson wrote: Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote: Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. If you want to be a stickler about it, peach-pi actually has a max98091. That requires code

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Doug Anderson
Tushar, On Mon, Jun 16, 2014 at 4:19 AM, Tushar Behera trbli...@gmail.com wrote: On 06/13/2014 10:33 PM, Doug Anderson wrote: Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote: Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. If you want to

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Mark Brown
On Mon, Jun 16, 2014 at 09:49:26AM -0700, Doug Anderson wrote: Yes please. I think there's supposed to be some official ordering of things. If anyone reading this has a pointer to the official sort order of things in the device tree I'd love to see it! ;) Most exact first I believe?

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Doug Anderson
Mark, On Mon, Jun 16, 2014 at 9:51 AM, Mark Brown broo...@kernel.org wrote: On Mon, Jun 16, 2014 at 09:49:26AM -0700, Doug Anderson wrote: Yes please. I think there's supposed to be some official ordering of things. If anyone reading this has a pointer to the official sort order of things

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On Mon, Jun 16, 2014 at 10:19 PM, Doug Anderson diand...@google.com wrote: Tushar, On Mon, Jun 16, 2014 at 4:19 AM, Tushar Behera trbli...@gmail.com wrote: On 06/13/2014 10:33 PM, Doug Anderson wrote: Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote:

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Tushar Behera
On Mon, Jun 16, 2014 at 10:32 PM, Doug Anderson diand...@google.com wrote: Mark, On Mon, Jun 16, 2014 at 9:51 AM, Mark Brown broo...@kernel.org wrote: On Mon, Jun 16, 2014 at 09:49:26AM -0700, Doug Anderson wrote: Yes please. I think there's supposed to be some official ordering of things.

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-16 Thread Doug Anderson
Tushar, On Mon, Jun 16, 2014 at 8:36 PM, Tushar Behera trbli...@gmail.com wrote: On Mon, Jun 16, 2014 at 10:19 PM, Doug Anderson diand...@google.com wrote: Tushar, On Mon, Jun 16, 2014 at 4:19 AM, Tushar Behera trbli...@gmail.com wrote: On 06/13/2014 10:33 PM, Doug Anderson wrote: Tushar,

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Doug Anderson
Mark, On Fri, Jun 13, 2014 at 3:04 PM, Mark Brown wrote: > On Fri, Jun 13, 2014 at 02:58:26PM -0700, Doug Anderson wrote: > >> Anyway, suffice to say that the i2c core needs to be extended to >> handle the idea that a single device has more than one "compatible" >> string. I'll leave it to an

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Mark Brown
On Fri, Jun 13, 2014 at 02:58:26PM -0700, Doug Anderson wrote: > Anyway, suffice to say that the i2c core needs to be extended to > handle the idea that a single device has more than one "compatible" > string. I'll leave it to an eager reader of this thread to implement > this since we can also

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Doug Anderson
Mark, On Fri, Jun 13, 2014 at 10:13 AM, Doug Anderson wrote: > Mark, > > On Fri, Jun 13, 2014 at 10:05 AM, Mark Brown wrote: >> On Fri, Jun 13, 2014 at 10:03:50AM -0700, Doug Anderson wrote: >>> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera >>> wrote: >> >>> > Peach-pi board has MAX98090

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Doug Anderson
Mark, On Fri, Jun 13, 2014 at 10:05 AM, Mark Brown wrote: > On Fri, Jun 13, 2014 at 10:03:50AM -0700, Doug Anderson wrote: >> On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: > >> > Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. > >> If you want to be a stickler about

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Mark Brown
On Fri, Jun 13, 2014 at 10:03:50AM -0700, Doug Anderson wrote: > On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: > > Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. > If you want to be a stickler about it, peach-pi actually has a > max98091. That requires code changes

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Doug Anderson
Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera wrote: > Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. If you want to be a stickler about it, peach-pi actually has a max98091. That requires code changes to the i2c driver, though. ...and unfortunately listing two

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Doug Anderson
Tushar, On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote: Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. If you want to be a stickler about it, peach-pi actually has a max98091. That requires code changes to the i2c driver, though. ...and

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Mark Brown
On Fri, Jun 13, 2014 at 10:03:50AM -0700, Doug Anderson wrote: On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote: Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. If you want to be a stickler about it, peach-pi actually has a max98091. That

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Doug Anderson
Mark, On Fri, Jun 13, 2014 at 10:05 AM, Mark Brown broo...@kernel.org wrote: On Fri, Jun 13, 2014 at 10:03:50AM -0700, Doug Anderson wrote: On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com wrote: Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. If you

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Doug Anderson
Mark, On Fri, Jun 13, 2014 at 10:13 AM, Doug Anderson diand...@google.com wrote: Mark, On Fri, Jun 13, 2014 at 10:05 AM, Mark Brown broo...@kernel.org wrote: On Fri, Jun 13, 2014 at 10:03:50AM -0700, Doug Anderson wrote: On Tue, Jun 10, 2014 at 10:32 PM, Tushar Behera tusha...@samsung.com

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Mark Brown
On Fri, Jun 13, 2014 at 02:58:26PM -0700, Doug Anderson wrote: Anyway, suffice to say that the i2c core needs to be extended to handle the idea that a single device has more than one compatible string. I'll leave it to an eager reader of this thread to implement this since we can also fix

Re: [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-13 Thread Doug Anderson
Mark, On Fri, Jun 13, 2014 at 3:04 PM, Mark Brown broo...@kernel.org wrote: On Fri, Jun 13, 2014 at 02:58:26PM -0700, Doug Anderson wrote: Anyway, suffice to say that the i2c core needs to be extended to handle the idea that a single device has more than one compatible string. I'll leave it

[PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-10 Thread Tushar Behera
Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. Signed-off-by: Tushar Behera --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 31 + 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts

[PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board

2014-06-10 Thread Tushar Behera
Peach-pi board has MAX98090 audio codec connected on HSI2C-7 bus. Signed-off-by: Tushar Behera tusha...@samsung.com --- arch/arm/boot/dts/exynos5800-peach-pi.dts | 31 + 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts