Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-31 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > On Monday 31 October 2016, Finn Thain wrote: > > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > > Read back MODE_REG after writing it in NCR5380_init() to check if the > > > chip is really there. > > > > > > This prevents hang when incorrect I/O address was

Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-31 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > On Monday 31 October 2016, Finn Thain wrote: > > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > > Read back MODE_REG after writing it in NCR5380_init() to check if the > > > chip is really there. > > > > > > This prevents hang when incorrect I/O address was

Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-31 Thread Ondrej Zary
On Monday 31 October 2016, Finn Thain wrote: > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > Read back MODE_REG after writing it in NCR5380_init() to check if the > > chip is really there. > > > > This prevents hang when incorrect I/O address was specified by user. > > > > Signed-off-by: Ondrej Zary

Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-31 Thread Ondrej Zary
On Monday 31 October 2016, Finn Thain wrote: > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > Read back MODE_REG after writing it in NCR5380_init() to check if the > > chip is really there. > > > > This prevents hang when incorrect I/O address was specified by user. > > > > Signed-off-by: Ondrej Zary

Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-30 Thread Finn Thain
On Sun, 30 Oct 2016, Ondrej Zary wrote: > Read back MODE_REG after writing it in NCR5380_init() to check if the > chip is really there. > > This prevents hang when incorrect I/O address was specified by user. Do you know whereabouts in the driver the hang happens? Maybe there is a robustness

Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-30 Thread Finn Thain
On Sun, 30 Oct 2016, Ondrej Zary wrote: > Read back MODE_REG after writing it in NCR5380_init() to check if the > chip is really there. > > This prevents hang when incorrect I/O address was specified by user. Do you know whereabouts in the driver the hang happens? Maybe there is a robustness

Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-30 Thread Finn Thain
On Sun, 30 Oct 2016, Ondrej Zary wrote: > Read back MODE_REG after writing it in NCR5380_init() to check if the > chip is really there. > > This prevents hang when incorrect I/O address was specified by user. > > Signed-off-by: Ondrej Zary > --- >

Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-30 Thread Finn Thain
On Sun, 30 Oct 2016, Ondrej Zary wrote: > Read back MODE_REG after writing it in NCR5380_init() to check if the > chip is really there. > > This prevents hang when incorrect I/O address was specified by user. > > Signed-off-by: Ondrej Zary > --- > drivers/scsi/NCR5380.c |5 + > 1

[PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-30 Thread Ondrej Zary
Read back MODE_REG after writing it in NCR5380_init() to check if the chip is really there. This prevents hang when incorrect I/O address was specified by user. Signed-off-by: Ondrej Zary --- drivers/scsi/NCR5380.c |5 + 1 file changed, 5 insertions(+) diff

[PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-30 Thread Ondrej Zary
Read back MODE_REG after writing it in NCR5380_init() to check if the chip is really there. This prevents hang when incorrect I/O address was specified by user. Signed-off-by: Ondrej Zary --- drivers/scsi/NCR5380.c |5 + 1 file changed, 5 insertions(+) diff --git