Re: [PATCH 3/3] btrfs: check io_ctl_prepare_pages return in __btrfs_write_out_cache

2015-02-22 Thread Liu Bo
On Tue, Feb 17, 2015 at 02:51:09AM -0800, Omar Sandoval wrote: > If io_ctl_prepare_pages fails, the pages in io_ctl.pages are not valid. > When we try to access them later, things will blow up in various ways. > Looks good. Reviewed-by: Liu Bo > Signed-off-by: Omar Sandoval > --- > fs/btrfs/

[PATCH 3/3] btrfs: check io_ctl_prepare_pages return in __btrfs_write_out_cache

2015-02-17 Thread Omar Sandoval
If io_ctl_prepare_pages fails, the pages in io_ctl.pages are not valid. When we try to access them later, things will blow up in various ways. Signed-off-by: Omar Sandoval --- fs/btrfs/free-space-cache.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/free