Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 29.03.2016 13:19, Viresh Kumar wrote: > On 29-03-16, 09:48, Viresh Kumar wrote: >> On 29-03-16, 13:10, Krzysztof Kozlowski wrote: >>> On 24.03.2016 15:40, Viresh Kumar wrote: The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform device now, reuse that and remove similar code from platform code. Signed-off-by: Viresh Kumar--- arch/arm/mach-exynos/exynos.c| 25 - drivers/cpufreq/cpufreq-dt-platdev.c | 5 + 2 files changed, 5 insertions(+), 25 deletions(-) >>> >>> Looks fine to me... except that it is a little bit outdated. Please >>> rebase on v4.6-rc1 because Bartlomiej added support for cpufreq @Exynos542x. >> >> Yeah, I know. I already have the updated version. > > Here it is: > > From: Viresh Kumar > Date: Thu, 24 Mar 2016 12:04:10 +0530 > Subject: [PATCH] cpufreq: exynos: Use generic platdev driver > > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > device now, reuse that and remove similar code from platform code. > > Signed-off-by: Viresh Kumar > --- > arch/arm/mach-exynos/exynos.c| 29 - > drivers/cpufreq/cpufreq-dt-platdev.c | 9 + > 2 files changed, 9 insertions(+), 29 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 29.03.2016 13:19, Viresh Kumar wrote: > On 29-03-16, 09:48, Viresh Kumar wrote: >> On 29-03-16, 13:10, Krzysztof Kozlowski wrote: >>> On 24.03.2016 15:40, Viresh Kumar wrote: The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform device now, reuse that and remove similar code from platform code. Signed-off-by: Viresh Kumar --- arch/arm/mach-exynos/exynos.c| 25 - drivers/cpufreq/cpufreq-dt-platdev.c | 5 + 2 files changed, 5 insertions(+), 25 deletions(-) >>> >>> Looks fine to me... except that it is a little bit outdated. Please >>> rebase on v4.6-rc1 because Bartlomiej added support for cpufreq @Exynos542x. >> >> Yeah, I know. I already have the updated version. > > Here it is: > > From: Viresh Kumar > Date: Thu, 24 Mar 2016 12:04:10 +0530 > Subject: [PATCH] cpufreq: exynos: Use generic platdev driver > > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > device now, reuse that and remove similar code from platform code. > > Signed-off-by: Viresh Kumar > --- > arch/arm/mach-exynos/exynos.c| 29 - > drivers/cpufreq/cpufreq-dt-platdev.c | 9 + > 2 files changed, 9 insertions(+), 29 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 29-03-16, 09:48, Viresh Kumar wrote: > On 29-03-16, 13:10, Krzysztof Kozlowski wrote: > > On 24.03.2016 15:40, Viresh Kumar wrote: > > > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > > > device now, reuse that and remove similar code from platform code. > > > > > > Signed-off-by: Viresh Kumar> > > --- > > > arch/arm/mach-exynos/exynos.c| 25 - > > > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > > > 2 files changed, 5 insertions(+), 25 deletions(-) > > > > Looks fine to me... except that it is a little bit outdated. Please > > rebase on v4.6-rc1 because Bartlomiej added support for cpufreq @Exynos542x. > > Yeah, I know. I already have the updated version. Here it is: From: Viresh Kumar Date: Thu, 24 Mar 2016 12:04:10 +0530 Subject: [PATCH] cpufreq: exynos: Use generic platdev driver The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform device now, reuse that and remove similar code from platform code. Signed-off-by: Viresh Kumar --- arch/arm/mach-exynos/exynos.c| 29 - drivers/cpufreq/cpufreq-dt-platdev.c | 9 + 2 files changed, 9 insertions(+), 29 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index bbf51a46f772..4d3b056fd786 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -213,33 +213,6 @@ static void __init exynos_init_irq(void) exynos_map_pmu(); } -static const struct of_device_id exynos_cpufreq_matches[] = { - { .compatible = "samsung,exynos3250", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4210", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4212", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4412", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos5250", .data = "cpufreq-dt" }, -#ifndef CONFIG_BL_SWITCHER - { .compatible = "samsung,exynos5420", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos5800", .data = "cpufreq-dt" }, -#endif - { /* sentinel */ } -}; - -static void __init exynos_cpufreq_init(void) -{ - struct device_node *root = of_find_node_by_path("/"); - const struct of_device_id *match; - - match = of_match_node(exynos_cpufreq_matches, root); - if (!match) { - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); - return; - } - - platform_device_register_simple(match->data, -1, NULL, 0); -} - static void __init exynos_dt_machine_init(void) { /* @@ -262,8 +235,6 @@ static void __init exynos_dt_machine_init(void) of_machine_is_compatible("samsung,exynos5250")) platform_device_register(_cpuidle); - exynos_cpufreq_init(); - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); } diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index 18b81724ca0b..f85d1ab5d621 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq/cpufreq-dt-platdev.c @@ -20,6 +20,15 @@ struct cpufreq_dt_compat { }; static struct cpufreq_dt_compat compat[] = { + { "samsung,exynos3250", NULL, 0 }, + { "samsung,exynos4210", NULL, 0 }, + { "samsung,exynos4212", NULL, 0 }, + { "samsung,exynos4412", NULL, 0 }, + { "samsung,exynos5250", NULL, 0 }, +#ifndef CONFIG_BL_SWITCHER + { "samsung,exynos5420", NULL, 0 }, + { "samsung,exynos5800", NULL, 0 }, +#endif }; static int __init cpufreq_dt_platdev_init(void) -- viresh
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 29-03-16, 09:48, Viresh Kumar wrote: > On 29-03-16, 13:10, Krzysztof Kozlowski wrote: > > On 24.03.2016 15:40, Viresh Kumar wrote: > > > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > > > device now, reuse that and remove similar code from platform code. > > > > > > Signed-off-by: Viresh Kumar > > > --- > > > arch/arm/mach-exynos/exynos.c| 25 - > > > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > > > 2 files changed, 5 insertions(+), 25 deletions(-) > > > > Looks fine to me... except that it is a little bit outdated. Please > > rebase on v4.6-rc1 because Bartlomiej added support for cpufreq @Exynos542x. > > Yeah, I know. I already have the updated version. Here it is: From: Viresh Kumar Date: Thu, 24 Mar 2016 12:04:10 +0530 Subject: [PATCH] cpufreq: exynos: Use generic platdev driver The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform device now, reuse that and remove similar code from platform code. Signed-off-by: Viresh Kumar --- arch/arm/mach-exynos/exynos.c| 29 - drivers/cpufreq/cpufreq-dt-platdev.c | 9 + 2 files changed, 9 insertions(+), 29 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index bbf51a46f772..4d3b056fd786 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -213,33 +213,6 @@ static void __init exynos_init_irq(void) exynos_map_pmu(); } -static const struct of_device_id exynos_cpufreq_matches[] = { - { .compatible = "samsung,exynos3250", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4210", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4212", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4412", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos5250", .data = "cpufreq-dt" }, -#ifndef CONFIG_BL_SWITCHER - { .compatible = "samsung,exynos5420", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos5800", .data = "cpufreq-dt" }, -#endif - { /* sentinel */ } -}; - -static void __init exynos_cpufreq_init(void) -{ - struct device_node *root = of_find_node_by_path("/"); - const struct of_device_id *match; - - match = of_match_node(exynos_cpufreq_matches, root); - if (!match) { - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); - return; - } - - platform_device_register_simple(match->data, -1, NULL, 0); -} - static void __init exynos_dt_machine_init(void) { /* @@ -262,8 +235,6 @@ static void __init exynos_dt_machine_init(void) of_machine_is_compatible("samsung,exynos5250")) platform_device_register(_cpuidle); - exynos_cpufreq_init(); - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); } diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index 18b81724ca0b..f85d1ab5d621 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq/cpufreq-dt-platdev.c @@ -20,6 +20,15 @@ struct cpufreq_dt_compat { }; static struct cpufreq_dt_compat compat[] = { + { "samsung,exynos3250", NULL, 0 }, + { "samsung,exynos4210", NULL, 0 }, + { "samsung,exynos4212", NULL, 0 }, + { "samsung,exynos4412", NULL, 0 }, + { "samsung,exynos5250", NULL, 0 }, +#ifndef CONFIG_BL_SWITCHER + { "samsung,exynos5420", NULL, 0 }, + { "samsung,exynos5800", NULL, 0 }, +#endif }; static int __init cpufreq_dt_platdev_init(void) -- viresh
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 29-03-16, 13:10, Krzysztof Kozlowski wrote: > On 24.03.2016 15:40, Viresh Kumar wrote: > > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > > device now, reuse that and remove similar code from platform code. > > > > Signed-off-by: Viresh Kumar> > --- > > arch/arm/mach-exynos/exynos.c| 25 - > > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > > 2 files changed, 5 insertions(+), 25 deletions(-) > > Looks fine to me... except that it is a little bit outdated. Please > rebase on v4.6-rc1 because Bartlomiej added support for cpufreq @Exynos542x. Yeah, I know. I already have the updated version. -- viresh
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 29-03-16, 13:10, Krzysztof Kozlowski wrote: > On 24.03.2016 15:40, Viresh Kumar wrote: > > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > > device now, reuse that and remove similar code from platform code. > > > > Signed-off-by: Viresh Kumar > > --- > > arch/arm/mach-exynos/exynos.c| 25 - > > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > > 2 files changed, 5 insertions(+), 25 deletions(-) > > Looks fine to me... except that it is a little bit outdated. Please > rebase on v4.6-rc1 because Bartlomiej added support for cpufreq @Exynos542x. Yeah, I know. I already have the updated version. -- viresh
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 24.03.2016 15:40, Viresh Kumar wrote: > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > device now, reuse that and remove similar code from platform code. > > Signed-off-by: Viresh Kumar> --- > arch/arm/mach-exynos/exynos.c| 25 - > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > 2 files changed, 5 insertions(+), 25 deletions(-) Looks fine to me... except that it is a little bit outdated. Please rebase on v4.6-rc1 because Bartlomiej added support for cpufreq @Exynos542x. Best regards, Krzysztof
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 24.03.2016 15:40, Viresh Kumar wrote: > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > device now, reuse that and remove similar code from platform code. > > Signed-off-by: Viresh Kumar > --- > arch/arm/mach-exynos/exynos.c| 25 - > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > 2 files changed, 5 insertions(+), 25 deletions(-) Looks fine to me... except that it is a little bit outdated. Please rebase on v4.6-rc1 because Bartlomiej added support for cpufreq @Exynos542x. Best regards, Krzysztof
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 29-03-16, 11:35, Krzysztof Kozlowski wrote: > On 24.03.2016 15:40, Viresh Kumar wrote: > > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > > device now, reuse that and remove similar code from platform code. > > > > Signed-off-by: Viresh Kumar> > --- > > arch/arm/mach-exynos/exynos.c| 25 - > > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > > 2 files changed, 5 insertions(+), 25 deletions(-) > > Hi, > > I got only 3rd patch (and no cover letter). I don't know what is the > background or what is your plan for this. I suppose you want to merge it > through cupfreq tree? Anyway could you cc-me on everything (or at least > cover letter)? I bounced (mutt is great) all the other mails to you just now. -- viresh
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 29-03-16, 11:35, Krzysztof Kozlowski wrote: > On 24.03.2016 15:40, Viresh Kumar wrote: > > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > > device now, reuse that and remove similar code from platform code. > > > > Signed-off-by: Viresh Kumar > > --- > > arch/arm/mach-exynos/exynos.c| 25 - > > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > > 2 files changed, 5 insertions(+), 25 deletions(-) > > Hi, > > I got only 3rd patch (and no cover letter). I don't know what is the > background or what is your plan for this. I suppose you want to merge it > through cupfreq tree? Anyway could you cc-me on everything (or at least > cover letter)? I bounced (mutt is great) all the other mails to you just now. -- viresh
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 24.03.2016 15:40, Viresh Kumar wrote: > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > device now, reuse that and remove similar code from platform code. > > Signed-off-by: Viresh Kumar> --- > arch/arm/mach-exynos/exynos.c| 25 - > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > 2 files changed, 5 insertions(+), 25 deletions(-) Hi, I got only 3rd patch (and no cover letter). I don't know what is the background or what is your plan for this. I suppose you want to merge it through cupfreq tree? Anyway could you cc-me on everything (or at least cover letter)? Best regards, Krzysztof
Re: [PATCH 3/3] cpufreq: exynos: Use generic platdev driver
On 24.03.2016 15:40, Viresh Kumar wrote: > The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform > device now, reuse that and remove similar code from platform code. > > Signed-off-by: Viresh Kumar > --- > arch/arm/mach-exynos/exynos.c| 25 - > drivers/cpufreq/cpufreq-dt-platdev.c | 5 + > 2 files changed, 5 insertions(+), 25 deletions(-) Hi, I got only 3rd patch (and no cover letter). I don't know what is the background or what is your plan for this. I suppose you want to merge it through cupfreq tree? Anyway could you cc-me on everything (or at least cover letter)? Best regards, Krzysztof
[PATCH 3/3] cpufreq: exynos: Use generic platdev driver
The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform device now, reuse that and remove similar code from platform code. Signed-off-by: Viresh Kumar--- arch/arm/mach-exynos/exynos.c| 25 - drivers/cpufreq/cpufreq-dt-platdev.c | 5 + 2 files changed, 5 insertions(+), 25 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 1c47aee31e9c..757c6012989c 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -224,29 +224,6 @@ static void __init exynos_init_irq(void) exynos_map_pmu(); } -static const struct of_device_id exynos_cpufreq_matches[] = { - { .compatible = "samsung,exynos3250", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4210", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4212", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4412", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos5250", .data = "cpufreq-dt" }, - { /* sentinel */ } -}; - -static void __init exynos_cpufreq_init(void) -{ - struct device_node *root = of_find_node_by_path("/"); - const struct of_device_id *match; - - match = of_match_node(exynos_cpufreq_matches, root); - if (!match) { - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); - return; - } - - platform_device_register_simple(match->data, -1, NULL, 0); -} - static void __init exynos_dt_machine_init(void) { /* @@ -269,8 +246,6 @@ static void __init exynos_dt_machine_init(void) of_machine_is_compatible("samsung,exynos5250")) platform_device_register(_cpuidle); - exynos_cpufreq_init(); - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); } diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index 18b81724ca0b..d7e62528ce06 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq/cpufreq-dt-platdev.c @@ -20,6 +20,11 @@ struct cpufreq_dt_compat { }; static struct cpufreq_dt_compat compat[] = { + { "samsung,exynos3250", NULL, 0 }, + { "samsung,exynos4210", NULL, 0 }, + { "samsung,exynos4212", NULL, 0 }, + { "samsung,exynos4412", NULL, 0 }, + { "samsung,exynos5250", NULL, 0 }, }; static int __init cpufreq_dt_platdev_init(void) -- 2.7.1.410.g6faf27b
[PATCH 3/3] cpufreq: exynos: Use generic platdev driver
The cpufreq-dt-platdev driver supports creation of cpufreq-dt platform device now, reuse that and remove similar code from platform code. Signed-off-by: Viresh Kumar --- arch/arm/mach-exynos/exynos.c| 25 - drivers/cpufreq/cpufreq-dt-platdev.c | 5 + 2 files changed, 5 insertions(+), 25 deletions(-) diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 1c47aee31e9c..757c6012989c 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -224,29 +224,6 @@ static void __init exynos_init_irq(void) exynos_map_pmu(); } -static const struct of_device_id exynos_cpufreq_matches[] = { - { .compatible = "samsung,exynos3250", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4210", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4212", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos4412", .data = "cpufreq-dt" }, - { .compatible = "samsung,exynos5250", .data = "cpufreq-dt" }, - { /* sentinel */ } -}; - -static void __init exynos_cpufreq_init(void) -{ - struct device_node *root = of_find_node_by_path("/"); - const struct of_device_id *match; - - match = of_match_node(exynos_cpufreq_matches, root); - if (!match) { - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); - return; - } - - platform_device_register_simple(match->data, -1, NULL, 0); -} - static void __init exynos_dt_machine_init(void) { /* @@ -269,8 +246,6 @@ static void __init exynos_dt_machine_init(void) of_machine_is_compatible("samsung,exynos5250")) platform_device_register(_cpuidle); - exynos_cpufreq_init(); - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); } diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c index 18b81724ca0b..d7e62528ce06 100644 --- a/drivers/cpufreq/cpufreq-dt-platdev.c +++ b/drivers/cpufreq/cpufreq-dt-platdev.c @@ -20,6 +20,11 @@ struct cpufreq_dt_compat { }; static struct cpufreq_dt_compat compat[] = { + { "samsung,exynos3250", NULL, 0 }, + { "samsung,exynos4210", NULL, 0 }, + { "samsung,exynos4212", NULL, 0 }, + { "samsung,exynos4412", NULL, 0 }, + { "samsung,exynos5250", NULL, 0 }, }; static int __init cpufreq_dt_platdev_init(void) -- 2.7.1.410.g6faf27b