Re: [PATCH 3/3] drivers/misc/sgi-gru: fix return of error

2015-09-26 Thread Dimitri Sivanich
Acked-by: Dimitri Sivanich On Mon, Sep 21, 2015 at 03:48:19PM +0530, Sudip Mukherjee wrote: > If kzalloc() fails then gms is NULL and we are returning NULL, but the > functions which called this function gru_register_mmu_notifier() are not > expecting NULL as the return. They are expecting

Re: [PATCH 3/3] drivers/misc/sgi-gru: fix return of error

2015-09-26 Thread Dimitri Sivanich
Acked-by: Dimitri Sivanich On Mon, Sep 21, 2015 at 03:48:19PM +0530, Sudip Mukherjee wrote: > If kzalloc() fails then gms is NULL and we are returning NULL, but the > functions which called this function gru_register_mmu_notifier() are not > expecting NULL as the return. They

[PATCH 3/3] drivers/misc/sgi-gru: fix return of error

2015-09-21 Thread Sudip Mukherjee
If kzalloc() fails then gms is NULL and we are returning NULL, but the functions which called this function gru_register_mmu_notifier() are not expecting NULL as the return. They are expecting either a valid pointer or the error code in ERR_PTR. Signed-off-by: Sudip Mukherjee --- The patch at

[PATCH 3/3] drivers/misc/sgi-gru: fix return of error

2015-09-21 Thread Sudip Mukherjee
If kzalloc() fails then gms is NULL and we are returning NULL, but the functions which called this function gru_register_mmu_notifier() are not expecting NULL as the return. They are expecting either a valid pointer or the error code in ERR_PTR. Signed-off-by: Sudip Mukherjee