Re: [PATCH 3/3] dt-bindings: thermal: Add binding document for mt6873 thermal controller

2020-12-07 Thread Rob Herring 
On Mon, Dec 07, 2020 at 02:31:27PM +0800, Michael Kao wrote:
> This patch adds binding document for mt6873 thermal controller.
> 
> Signed-off-by: Michael Kao 
> ---
>  .../thermal/mediatek-thermal-lvts.yaml| 80 +++
>  1 file changed, 80 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> 
> diff --git 
> a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml 
> b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> new file mode 100644
> index ..745611718c0a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/mediatek-thermal-lvts.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek SoC LVTS thermal controller (DTS) binding
> +
> +maintainers:
> +  - Yu-Chia Chang , Michael Kao 
> 

Not the right format. 1 email per entry.

> +
> +properties:
> +  compatible:
> +const: mediatek,mt6873-lvts
> +
> +  reg:
> +maxItems: 1
> +
> +  interrupts:
> +maxItems: 1
> +
> +  clocks:
> +maxItems: 1
> +
> +  clock-names:
> +items:
> +  - const: lvts_clk
> +
> +  "#thermal-sensor-cells":
> +const: 0
> +
> +required:
> +  - "#thermal-sensor-cells"
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +#include 
> +#include 
> +#include 
> +dts: lvts@1100b000 {
> +compatible = "mediatek,mt6873-lvts";
> +reg = <0x1100b000 0x1000>;
> +clocks = < CLK_INFRA_THERM>;
> +clock-names = "lvts_clk";
> +#thermal-sensor-cells = <0>;
> +interrupts = ;
> +};
> +
> +thermal-zones {
> +cpu_thermal: cpu-thermal {
> +polling-delay-passive = <0>;
> +polling-delay = <0>;
> +
> +thermal-sensors = <>;
> +trips {
> +cpu_alert1: cpu-alert1 {
> +temperature = <85000>;
> +hysteresis = <0>;
> +type = "passive";
> +};
> +
> +cpu_crit: cpu-crit {
> +temperature = <12>;
> +hysteresis = <0>;
> +type = "critical";
> +};
> +};
> +
> +cooling-maps {
> +};
> +};
> +};
> +...
> -- 
> 2.18.0
>

Re: [PATCH 3/3] dt-bindings: thermal: Add binding document for mt6873 thermal controller

2020-12-07 Thread Rob Herring 
On Mon, 07 Dec 2020 14:31:27 +0800, Michael Kao wrote:
> This patch adds binding document for mt6873 thermal controller.
> 
> Signed-off-by: Michael Kao 
> ---
>  .../thermal/mediatek-thermal-lvts.yaml| 80 +++
>  1 file changed, 80 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.example.dts:21:18:
 fatal error: dt-bindings/clock/mt8192-clk.h: No such file or directory
   21 | #include 
  |  ^~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:342: 
Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.example.dt.yaml]
 Error 1
make[1]: *** Waiting for unfinished jobs
make: *** [Makefile:1364: dt_binding_check] Error 2


See https://patchwork.ozlabs.org/patch/1411898

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

[PATCH 3/3] dt-bindings: thermal: Add binding document for mt6873 thermal controller

2020-12-06 Thread Michael Kao 
This patch adds binding document for mt6873 thermal controller.

Signed-off-by: Michael Kao 
---
 .../thermal/mediatek-thermal-lvts.yaml| 80 +++
 1 file changed, 80 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml

diff --git 
a/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml 
b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
new file mode 100644
index ..745611718c0a
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal-lvts.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/mediatek-thermal-lvts.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek SoC LVTS thermal controller (DTS) binding
+
+maintainers:
+  - Yu-Chia Chang , Michael Kao 

+
+properties:
+  compatible:
+const: mediatek,mt6873-lvts
+
+  reg:
+maxItems: 1
+
+  interrupts:
+maxItems: 1
+
+  clocks:
+maxItems: 1
+
+  clock-names:
+items:
+  - const: lvts_clk
+
+  "#thermal-sensor-cells":
+const: 0
+
+required:
+  - "#thermal-sensor-cells"
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+#include 
+#include 
+#include 
+dts: lvts@1100b000 {
+compatible = "mediatek,mt6873-lvts";
+reg = <0x1100b000 0x1000>;
+clocks = < CLK_INFRA_THERM>;
+clock-names = "lvts_clk";
+#thermal-sensor-cells = <0>;
+interrupts = ;
+};
+
+thermal-zones {
+cpu_thermal: cpu-thermal {
+polling-delay-passive = <0>;
+polling-delay = <0>;
+
+thermal-sensors = <>;
+trips {
+cpu_alert1: cpu-alert1 {
+temperature = <85000>;
+hysteresis = <0>;
+type = "passive";
+};
+
+cpu_crit: cpu-crit {
+temperature = <12>;
+hysteresis = <0>;
+type = "critical";
+};
+};
+
+cooling-maps {
+};
+};
+};
+...
-- 
2.18.0