Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread Andy Shevchenko
On Fri, Jul 13, 2012 at 1:30 PM, viresh kumar wrote: > Sorry, got confused now. What works without this patch? And what doesn't work > without it? It seems this patch is redundant. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread viresh kumar
On 13/07/12 11:04, Andy Shevchenko wrote: > On Fri, Jul 13, 2012 at 11:56 AM, viresh kumar wrote: >> I wanted to ask, will normal memcpy for anybody will work with unaligned >> addresses >> with this patch? I believe they will. > Hmm... I just rechecked and it seems it works without this patch.

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread Andy Shevchenko
On Fri, Jul 13, 2012 at 11:56 AM, viresh kumar wrote: > I wanted to ask, will normal memcpy for anybody will work with unaligned > addresses > with this patch? I believe they will. Hmm... I just rechecked and it seems it works without this patch. I didn't remember why this patch still in my

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread viresh kumar
On 13/07/12 09:45, Andy Shevchenko wrote: >> > To understand it more, what does this mean? We will not support >> > transfers with unaligned >> > addresses/length to word size? > The dmatest module uses those constants to get source, destination > addresses and length of the test data aligned. On

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread Andy Shevchenko
On Fri, Jul 13, 2012 at 11:26 AM, viresh kumar wrote: > It would be nice to keep spear-devel in cc, as this is the second > platform that uses this driver. I used to get the list of recipients via get_maintainer script. Will try to not forget about that address in the future. >> The default

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread viresh kumar
It would be nice to keep spear-devel in cc, as this is the second platform that uses this driver. On Fri, Jul 13, 2012 at 9:09 AM, Andy Shevchenko wrote: > The default values are filled to support at least mem-to-mem tests provided by > dmatest module. It makes sense to choose the 4 bytes (2

[PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread Andy Shevchenko
The default values are filled to support at least mem-to-mem tests provided by dmatest module. It makes sense to choose the 4 bytes (2 least significant bits) alignment by the default. Signed-off-by: Andy Shevchenko --- drivers/dma/dw_dmac.c |6 ++ 1 file changed, 6 insertions(+) diff

[PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread Andy Shevchenko
The default values are filled to support at least mem-to-mem tests provided by dmatest module. It makes sense to choose the 4 bytes (2 least significant bits) alignment by the default. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c |6 ++ 1

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread viresh kumar
It would be nice to keep spear-devel in cc, as this is the second platform that uses this driver. On Fri, Jul 13, 2012 at 9:09 AM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: The default values are filled to support at least mem-to-mem tests provided by dmatest module. It makes

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread Andy Shevchenko
On Fri, Jul 13, 2012 at 11:26 AM, viresh kumar viresh.ku...@linaro.org wrote: It would be nice to keep spear-devel in cc, as this is the second platform that uses this driver. I used to get the list of recipients via get_maintainer script. Will try to not forget about that address in the future.

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread viresh kumar
On 13/07/12 09:45, Andy Shevchenko wrote: To understand it more, what does this mean? We will not support transfers with unaligned addresses/length to word size? The dmatest module uses those constants to get source, destination addresses and length of the test data aligned. On the other

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread Andy Shevchenko
On Fri, Jul 13, 2012 at 11:56 AM, viresh kumar viresh.kum...@arm.com wrote: I wanted to ask, will normal memcpy for anybody will work with unaligned addresses with this patch? I believe they will. Hmm... I just rechecked and it seems it works without this patch. I didn't remember why this

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread viresh kumar
On 13/07/12 11:04, Andy Shevchenko wrote: On Fri, Jul 13, 2012 at 11:56 AM, viresh kumar viresh.kum...@arm.com wrote: I wanted to ask, will normal memcpy for anybody will work with unaligned addresses with this patch? I believe they will. Hmm... I just rechecked and it seems it works without

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread Andy Shevchenko
On Fri, Jul 13, 2012 at 1:30 PM, viresh kumar viresh.kum...@arm.com wrote: Sorry, got confused now. What works without this patch? And what doesn't work without it? It seems this patch is redundant. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line