Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Jeff Layton
On Thu, 1 Nov 2012 15:47:30 -0700 "Darrick J. Wong" wrote: > On Thu, Nov 01, 2012 at 04:22:54PM -0400, Jeff Layton wrote: > > On Thu, 1 Nov 2012 11:43:26 -0700 > > Boaz Harrosh wrote: > > > > > On 11/01/2012 12:58 AM, Darrick J. Wong wrote: > > > > Fix up the filesystems that provide their own

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Darrick J. Wong
On Thu, Nov 01, 2012 at 04:22:54PM -0400, Jeff Layton wrote: > On Thu, 1 Nov 2012 11:43:26 -0700 > Boaz Harrosh wrote: > > > On 11/01/2012 12:58 AM, Darrick J. Wong wrote: > > > Fix up the filesystems that provide their own ->page_mkwrite handlers to > > > provide stable page writes if

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Boaz Harrosh
On 11/01/2012 01:22 PM, Jeff Layton wrote: > Hmm...I don't know... > > I've never been crazy about using the page lock for this, but in the > absence of a better way to guarantee stable pages, it was what I ended > up with at the time. cifs_writepages will hold the page lock until >

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Jeff Layton
On Thu, 1 Nov 2012 11:43:26 -0700 Boaz Harrosh wrote: > On 11/01/2012 12:58 AM, Darrick J. Wong wrote: > > Fix up the filesystems that provide their own ->page_mkwrite handlers to > > provide stable page writes if necessary. > > > > Signed-off-by: Darrick J. Wong > > --- > > fs/9p/vfs_file.c

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Boaz Harrosh
On 11/01/2012 12:58 AM, Darrick J. Wong wrote: > Fix up the filesystems that provide their own ->page_mkwrite handlers to > provide stable page writes if necessary. > > Signed-off-by: Darrick J. Wong > --- > fs/9p/vfs_file.c |1 + > fs/afs/write.c |4 ++-- > fs/ceph/addr.c |1 +

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Jan Kara
On Thu 01-11-12 00:58:29, Darrick J. Wong wrote: > Fix up the filesystems that provide their own ->page_mkwrite handlers to > provide stable page writes if necessary. > > Signed-off-by: Darrick J. Wong > --- > fs/9p/vfs_file.c |1 + > fs/afs/write.c |4 ++-- > fs/ceph/addr.c |1

[PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Darrick J. Wong
Fix up the filesystems that provide their own ->page_mkwrite handlers to provide stable page writes if necessary. Signed-off-by: Darrick J. Wong --- fs/9p/vfs_file.c |1 + fs/afs/write.c |4 ++-- fs/ceph/addr.c |1 + fs/cifs/file.c |1 + fs/ocfs2/mmap.c |1 +

[PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Darrick J. Wong
Fix up the filesystems that provide their own -page_mkwrite handlers to provide stable page writes if necessary. Signed-off-by: Darrick J. Wong darrick.w...@oracle.com --- fs/9p/vfs_file.c |1 + fs/afs/write.c |4 ++-- fs/ceph/addr.c |1 + fs/cifs/file.c |1 +

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Jan Kara
On Thu 01-11-12 00:58:29, Darrick J. Wong wrote: Fix up the filesystems that provide their own -page_mkwrite handlers to provide stable page writes if necessary. Signed-off-by: Darrick J. Wong darrick.w...@oracle.com --- fs/9p/vfs_file.c |1 + fs/afs/write.c |4 ++--

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Boaz Harrosh
On 11/01/2012 12:58 AM, Darrick J. Wong wrote: Fix up the filesystems that provide their own -page_mkwrite handlers to provide stable page writes if necessary. Signed-off-by: Darrick J. Wong darrick.w...@oracle.com --- fs/9p/vfs_file.c |1 + fs/afs/write.c |4 ++--

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Jeff Layton
On Thu, 1 Nov 2012 11:43:26 -0700 Boaz Harrosh bharr...@panasas.com wrote: On 11/01/2012 12:58 AM, Darrick J. Wong wrote: Fix up the filesystems that provide their own -page_mkwrite handlers to provide stable page writes if necessary. Signed-off-by: Darrick J. Wong

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Boaz Harrosh
On 11/01/2012 01:22 PM, Jeff Layton wrote: Hmm...I don't know... I've never been crazy about using the page lock for this, but in the absence of a better way to guarantee stable pages, it was what I ended up with at the time. cifs_writepages will hold the page lock until kernel_sendmsg

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Darrick J. Wong
On Thu, Nov 01, 2012 at 04:22:54PM -0400, Jeff Layton wrote: On Thu, 1 Nov 2012 11:43:26 -0700 Boaz Harrosh bharr...@panasas.com wrote: On 11/01/2012 12:58 AM, Darrick J. Wong wrote: Fix up the filesystems that provide their own -page_mkwrite handlers to provide stable page writes if

Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback

2012-11-01 Thread Jeff Layton
On Thu, 1 Nov 2012 15:47:30 -0700 Darrick J. Wong darrick.w...@oracle.com wrote: On Thu, Nov 01, 2012 at 04:22:54PM -0400, Jeff Layton wrote: On Thu, 1 Nov 2012 11:43:26 -0700 Boaz Harrosh bharr...@panasas.com wrote: On 11/01/2012 12:58 AM, Darrick J. Wong wrote: Fix up the