Re: [PATCH 3/3] hwmon: tmp108: Update driver to use hwmon_chip_info.

2016-11-27 Thread Guenter Roeck
On 11/27/2016 06:10 PM, John Muir wrote: On 2016.11.27, at 15:00 , Guenter Roeck wrote: On Sat, Nov 26, 2016 at 09:15:37PM -0800, John Muir wrote: Move the tmp108 driver from hwmon attribute groups to hwmon_chip_info. Signed-off-by: John Muir --- Hi John, please have a look at the followi

Re: [PATCH 3/3] hwmon: tmp108: Update driver to use hwmon_chip_info.

2016-11-27 Thread John Muir
> On 2016.11.27, at 15:00 , Guenter Roeck wrote: > > On Sat, Nov 26, 2016 at 09:15:37PM -0800, John Muir wrote: >> Move the tmp108 driver from hwmon attribute groups to >> hwmon_chip_info. >> >> Signed-off-by: John Muir >> --- > > Hi John, > > please have a look at the following patch. > > S

Re: [PATCH 3/3] hwmon: tmp108: Update driver to use hwmon_chip_info.

2016-11-27 Thread Guenter Roeck
On Sat, Nov 26, 2016 at 09:15:37PM -0800, John Muir wrote: > Move the tmp108 driver from hwmon attribute groups to > hwmon_chip_info. > > Signed-off-by: John Muir > --- Hi John, please have a look at the following patch. Something else: Symbolic permissions are out of favor nowadays. You might

[PATCH 3/3] hwmon: tmp108: Update driver to use hwmon_chip_info.

2016-11-26 Thread John Muir
Move the tmp108 driver from hwmon attribute groups to hwmon_chip_info. Signed-off-by: John Muir --- drivers/hwmon/tmp108.c | 142 + 1 file changed, 73 insertions(+), 69 deletions(-) diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.c inde