Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 10:50 AM, Nicholas Mc Guire wrote: On Mon, 02 Feb 2015, Lars-Peter Clausen wrote: On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved

Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Nicholas Mc Guire
On Mon, 02 Feb 2015, Lars-Peter Clausen wrote: > On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: >> return type of wait_for_completion_timeout is unsigned long not int, rather >> than introducing a new variable the wait_for_completion_timeout is moved >> into the if condition as the return value

Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved into the if condition as the return value is only used to detect timeout. But the return value

[PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved into the if condition as the return value is only used to detect timeout. Signed-off-by: Nicholas Mc Guire --- Aside from the fixup of the

Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved into the if condition as the return value is only used to detect timeout. But the return value

Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Nicholas Mc Guire
On Mon, 02 Feb 2015, Lars-Peter Clausen wrote: On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved into the if condition as the return value is

Re: [PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Lars-Peter Clausen
On 02/02/2015 10:50 AM, Nicholas Mc Guire wrote: On Mon, 02 Feb 2015, Lars-Peter Clausen wrote: On 02/02/2015 09:37 AM, Nicholas Mc Guire wrote: return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved

[PATCH 3/3] iio: ad_sigma_delta: cleanup wait_for_completion return handling

2015-02-02 Thread Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int, rather than introducing a new variable the wait_for_completion_timeout is moved into the if condition as the return value is only used to detect timeout. Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- Aside from the