Re: [PATCH 3/3] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-12 Thread Petr Mladek
Hi, I have realized that I did not comment the two ideas. On Wed 2021-02-10 11:27:45, Timur Tabi wrote: > > > On 2/10/21 7:41 AM, Petr Mladek wrote: > > > > The option causes that vsprintf() will not hash pointers. Yes, it is > > primary used by printk(). But it is used also in some other > >

Re: [PATCH 3/3] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-10 Thread Timur Tabi
On 2/10/21 7:41 AM, Petr Mladek wrote: The option causes that vsprintf() will not hash pointers. Yes, it is primary used by printk(). But it is used also in some other interfaces, especially trace_printk(), seq_buf() API. The naked pointers might appear more or less anywhere, including

Re: [PATCH 3/3] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-10 Thread Petr Mladek
On Tue 2021-02-09 23:18:14, Timur Tabi wrote: > If the make-printk-non-secret command line parameter is set, then > printk("%p") will print pointers as unhashed. This is useful for > debugging purposes. > > A large warning message is displayed if this option is enabled. > Unhashed pointers,

Re: [PATCH 3/3] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-10 Thread Vlastimil Babka
On 2/10/21 6:18 AM, Timur Tabi wrote: > If the make-printk-non-secret command line parameter is set, then > printk("%p") will print pointers as unhashed. This is useful for > debugging purposes. > > A large warning message is displayed if this option is enabled. > Unhashed pointers, while useful

[PATCH 3/3] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

2021-02-09 Thread Timur Tabi
If the make-printk-non-secret command line parameter is set, then printk("%p") will print pointers as unhashed. This is useful for debugging purposes. A large warning message is displayed if this option is enabled. Unhashed pointers, while useful for debugging, expose kernel addresses which can