On Mon, 3 Aug 2020 at 10:05, Hans Verkuil wrote:
>
> On 03/08/2020 04:09, Santiago Hormazabal wrote:
> > This chip requires almost no support components and can used over I2C.
> > The driver uses the I2C bus and exposes the controls as a V4L2 radio.
> > Tested with a module that contains this
On 03/08/2020 04:09, Santiago Hormazabal wrote:
> This chip requires almost no support components and can used over I2C.
> The driver uses the I2C bus and exposes the controls as a V4L2 radio.
> Tested with a module that contains this chip (from SZZSJDZ.com,
> part number ZJ-801B, even tho the
This chip requires almost no support components and can used over I2C.
The driver uses the I2C bus and exposes the controls as a V4L2 radio.
Tested with a module that contains this chip (from SZZSJDZ.com,
part number ZJ-801B, even tho the company seems defunct now), and an H2+
AllWinner SoC
On Fri, 2020-07-17 at 12:04 +0200, Hans Verkuil wrote:
> On 17/07/2020 11:51, Joe Perches wrote:
> > On Fri, 2020-07-17 at 11:29 +0200, Hans Verkuil wrote:
> > > It's standard linux codingstyle to use lowercase for hex numbers.
> > > Can you change that throughout the source for the next version?
On Fri, 17 Jul 2020 at 06:29, Hans Verkuil wrote:
>
> Hi Santiago,
>
> Nice, it's been a long time since I last received a new radio driver :-)
>
> I have a bunch of comments below, nothing major.
>
> Main thing you need to do is to run 'checkpatch --strict' over the patch
> to fix codingstyle
On 17/07/2020 11:51, Joe Perches wrote:
> On Fri, 2020-07-17 at 11:29 +0200, Hans Verkuil wrote:
>> It's standard linux codingstyle to use lowercase for hex numbers.
>> Can you change that throughout the source for the next version?
>
> Is there a standard? It's not in coding-style.rst.
>
>
On Fri, 2020-07-17 at 11:29 +0200, Hans Verkuil wrote:
> It's standard linux codingstyle to use lowercase for hex numbers.
> Can you change that throughout the source for the next version?
Is there a standard? It's not in coding-style.rst.
While I prefer lowercase too, it seems the kernel has
Hi Santiago,
Nice, it's been a long time since I last received a new radio driver :-)
I have a bunch of comments below, nothing major.
Main thing you need to do is to run 'checkpatch --strict' over the patch
to fix codingstyle issues. And I realized that one corner of the API wasn't
checked by
This chip requires almost no support components and can used over I2C.
The driver uses the I2C bus and exposes the controls as a V4L2 radio.
Tested with a module that contains this chip (from SZZSJDZ.com,
part number ZJ-801B) and a H2+ AllWinner SoC running the master
(at this time) of the
9 matches
Mail list logo
