Re: [PATCH 3/3] media: ttpci: add RC_CORE dependency

2019-06-25 Thread Arnd Bergmann 
On Tue, Jun 25, 2019 at 12:56 PM Sean Young  wrote:
>
> On Mon, Jun 17, 2019 at 01:16:53PM +0200, Arnd Bergmann wrote:
> > The ttpci driver now uses the rc-core, so we need to ensure it
> > is enabled:
> >
> > ERROR: "rc_unregister_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] 
> > undefined!
> > ERROR: "rc_allocate_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] 
> > undefined!
> > ERROR: "rc_free_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
> > ERROR: "rc_keydown" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
> > ERROR: "rc_register_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] 
> > undefined!
> >
> > Fixes: 71f49a8bf5c5 ("media: ttpci: use rc-core for the IR receiver")
> > Signed-off-by: Arnd Bergmann 
>
> Thank you for the patch, unfortunately this was already fixed in
> commit 12e23ebb396e6ffea88b8c5e483059a297326afb (which was accepted
> after you sent your patch).

That seems like a better fix, thanks for addressing the issue!

  Arnd

Re: [PATCH 3/3] media: ttpci: add RC_CORE dependency

2019-06-25 Thread Sean Young 
On Mon, Jun 17, 2019 at 01:16:53PM +0200, Arnd Bergmann wrote:
> The ttpci driver now uses the rc-core, so we need to ensure it
> is enabled:
> 
> ERROR: "rc_unregister_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] 
> undefined!
> ERROR: "rc_allocate_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
> ERROR: "rc_free_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
> ERROR: "rc_keydown" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
> ERROR: "rc_register_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
> 
> Fixes: 71f49a8bf5c5 ("media: ttpci: use rc-core for the IR receiver")
> Signed-off-by: Arnd Bergmann 

Thank you for the patch, unfortunately this was already fixed in
commit 12e23ebb396e6ffea88b8c5e483059a297326afb (which was accepted
after you sent your patch).

Thanks
Sean

[PATCH 3/3] media: ttpci: add RC_CORE dependency

2019-06-17 Thread Arnd Bergmann 
The ttpci driver now uses the rc-core, so we need to ensure it
is enabled:

ERROR: "rc_unregister_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
ERROR: "rc_allocate_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
ERROR: "rc_free_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
ERROR: "rc_keydown" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!
ERROR: "rc_register_device" [drivers/media/pci/ttpci/dvb-ttpci.ko] undefined!

Fixes: 71f49a8bf5c5 ("media: ttpci: use rc-core for the IR receiver")
Signed-off-by: Arnd Bergmann 
---
 drivers/media/pci/ttpci/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/pci/ttpci/Kconfig b/drivers/media/pci/ttpci/Kconfig
index d96d4fa20457..70bc25fb0a6f 100644
--- a/drivers/media/pci/ttpci/Kconfig
+++ b/drivers/media/pci/ttpci/Kconfig
@@ -9,6 +9,7 @@ config DVB_AV7110
select VIDEO_SAA7146_VV
select DVB_AV7110_IR if INPUT_EVDEV=y || INPUT_EVDEV=DVB_AV7110
depends on VIDEO_DEV# dependencies of VIDEO_SAA7146_VV
+   depends on RC_CORE
select DVB_VES1820 if MEDIA_SUBDRV_AUTOSELECT
select DVB_VES1X93 if MEDIA_SUBDRV_AUTOSELECT
select DVB_STV0299 if MEDIA_SUBDRV_AUTOSELECT
-- 
2.20.0