Re: [PATCH 3/3] net: skb_queue_purge(): lock/unlock the list only once

2017-09-08 Thread Stephen Hemminger
On Fri, 08 Sep 2017 05:06:30 - Michael Witten wrote: > Date: Thu, 7 Sep 2017 20:07:40 + > With this commit, the list's lock is locked/unlocked only once > for the duration of `skb_queue_purge()'. > > Hitherto, the list's lock has been locked/unlocked every time > an

Re: [PATCH 3/3] net: skb_queue_purge(): lock/unlock the list only once

2017-09-08 Thread Stephen Hemminger
On Fri, 08 Sep 2017 05:06:30 - Michael Witten wrote: > Date: Thu, 7 Sep 2017 20:07:40 + > With this commit, the list's lock is locked/unlocked only once > for the duration of `skb_queue_purge()'. > > Hitherto, the list's lock has been locked/unlocked every time > an item is dequeued;

Re: [PATCH 3/3] net: skb_queue_purge(): lock/unlock the list only once

2017-09-08 Thread Eric Dumazet
On Fri, 2017-09-08 at 05:06 +, Michael Witten wrote: > Date: Thu, 7 Sep 2017 20:07:40 + > With this commit, the list's lock is locked/unlocked only once > for the duration of `skb_queue_purge()'. > > Hitherto, the list's lock has been locked/unlocked every time > an item is dequeued; this

Re: [PATCH 3/3] net: skb_queue_purge(): lock/unlock the list only once

2017-09-08 Thread Eric Dumazet
On Fri, 2017-09-08 at 05:06 +, Michael Witten wrote: > Date: Thu, 7 Sep 2017 20:07:40 + > With this commit, the list's lock is locked/unlocked only once > for the duration of `skb_queue_purge()'. > > Hitherto, the list's lock has been locked/unlocked every time > an item is dequeued; this

[PATCH 3/3] net: skb_queue_purge(): lock/unlock the list only once

2017-09-08 Thread Michael Witten
Date: Thu, 7 Sep 2017 20:07:40 + With this commit, the list's lock is locked/unlocked only once for the duration of `skb_queue_purge()'. Hitherto, the list's lock has been locked/unlocked every time an item is dequeued; this seems not only inefficient, but also incorrect, as the whole point

[PATCH 3/3] net: skb_queue_purge(): lock/unlock the list only once

2017-09-08 Thread Michael Witten
Date: Thu, 7 Sep 2017 20:07:40 + With this commit, the list's lock is locked/unlocked only once for the duration of `skb_queue_purge()'. Hitherto, the list's lock has been locked/unlocked every time an item is dequeued; this seems not only inefficient, but also incorrect, as the whole point