Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-04 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 04, 2013 at 11:11:17AM +0100, Ingo Molnar escreveu: > * Arnaldo Carvalho de Melo wrote: > > Em Mon, Dec 02, 2013 at 12:58:35PM -0700, David Ahern escreveu: > > > On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote: > > > Why not just --event-time? > > > Really should have dropped

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-04 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Mon, Dec 02, 2013 at 12:58:35PM -0700, David Ahern escreveu: > > On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote: > > >Can you suggest a better name for the option being discussed? > > > >Perhaps one of: > > > >--show-event-time > > >--event-time >

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-04 Thread Ingo Molnar
* Arnaldo Carvalho de Melo a...@ghostprotocols.net wrote: Em Mon, Dec 02, 2013 at 12:58:35PM -0700, David Ahern escreveu: On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote: Can you suggest a better name for the option being discussed? Perhaps one of: --show-event-time

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-04 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 04, 2013 at 11:11:17AM +0100, Ingo Molnar escreveu: * Arnaldo Carvalho de Melo a...@ghostprotocols.net wrote: Em Mon, Dec 02, 2013 at 12:58:35PM -0700, David Ahern escreveu: On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote: Why not just --event-time? Really should have

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread David Ahern
On 12/2/13, 1:17 PM, Arnaldo Carvalho de Melo wrote: Probably, yeah, Ingo made some point about using --show- for some reason, Ingo? One I can think of is that, in general, plain --feature can mean, at least, one of --enable-feature and --show-feature, so perhaps that is the point. But then,

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 02, 2013 at 12:58:35PM -0700, David Ahern escreveu: > On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote: > >Can you suggest a better name for the option being discussed? > >Perhaps one of: > >--show-event-time > >--event-time > >? > > Why not just --event-time? > Really

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread David Ahern
On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote: Can you suggest a better name for the option being discussed? Perhaps one of: --show-event-time --event-time ? Why not just --event-time? Really should have dropped the 'show' from the recent perf-script change (just --task-events and

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 02, 2013 at 12:25:26PM -0700, David Ahern escreveu: > On 12/2/13, 12:23 PM, Arnaldo Carvalho de Melo wrote: > >Em Mon, Dec 02, 2013 at 11:38:20PM +0900, Namhyung Kim escreveu: > >>2013-12-02 (월), 09:33 -0300, Arnaldo Carvalho de Melo: > >>>Em Mon, Dec 02, 2013 at 03:53:19PM +0900,

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread David Ahern
On 12/2/13, 12:23 PM, Arnaldo Carvalho de Melo wrote: Em Mon, Dec 02, 2013 at 11:38:20PM +0900, Namhyung Kim escreveu: Hi Arnaldo, 2013-12-02 (월), 09:33 -0300, Arnaldo Carvalho de Melo: Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim escreveu: From: Namhyung Kim The --show-time-info

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 02, 2013 at 11:38:20PM +0900, Namhyung Kim escreveu: > Hi Arnaldo, > > 2013-12-02 (월), 09:33 -0300, Arnaldo Carvalho de Melo: > > Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim escreveu: > > > From: Namhyung Kim > > > > > > The --show-time-info option is for displaying

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Namhyung Kim
Hi Arnaldo, 2013-12-02 (월), 09:33 -0300, Arnaldo Carvalho de Melo: > Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim escreveu: > > From: Namhyung Kim > > > > The --show-time-info option is for displaying elapsed sampling time > > Isn't that too long? Can't we use just --time/-t? Hmm..

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim escreveu: > From: Namhyung Kim > > The --show-time-info option is for displaying elapsed sampling time Isn't that too long? Can't we use just --time/-t? > information for each entry. > > $ perf record -- perf bench sched messaging > $

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim escreveu: From: Namhyung Kim namhyung@lge.com The --show-time-info option is for displaying elapsed sampling time Isn't that too long? Can't we use just --time/-t? information for each entry. $ perf record -- perf bench sched

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Namhyung Kim
Hi Arnaldo, 2013-12-02 (월), 09:33 -0300, Arnaldo Carvalho de Melo: Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim escreveu: From: Namhyung Kim namhyung@lge.com The --show-time-info option is for displaying elapsed sampling time Isn't that too long? Can't we use just

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 02, 2013 at 11:38:20PM +0900, Namhyung Kim escreveu: Hi Arnaldo, 2013-12-02 (월), 09:33 -0300, Arnaldo Carvalho de Melo: Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim escreveu: From: Namhyung Kim namhyung@lge.com The --show-time-info option is for displaying

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread David Ahern
On 12/2/13, 12:23 PM, Arnaldo Carvalho de Melo wrote: Em Mon, Dec 02, 2013 at 11:38:20PM +0900, Namhyung Kim escreveu: Hi Arnaldo, 2013-12-02 (월), 09:33 -0300, Arnaldo Carvalho de Melo: Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim escreveu: From: Namhyung Kim namhyung@lge.com

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 02, 2013 at 12:25:26PM -0700, David Ahern escreveu: On 12/2/13, 12:23 PM, Arnaldo Carvalho de Melo wrote: Em Mon, Dec 02, 2013 at 11:38:20PM +0900, Namhyung Kim escreveu: 2013-12-02 (월), 09:33 -0300, Arnaldo Carvalho de Melo: Em Mon, Dec 02, 2013 at 03:53:19PM +0900, Namhyung Kim

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread David Ahern
On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote: Can you suggest a better name for the option being discussed? Perhaps one of: --show-event-time --event-time ? Why not just --event-time? Really should have dropped the 'show' from the recent perf-script change (just --task-events and

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 02, 2013 at 12:58:35PM -0700, David Ahern escreveu: On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote: Can you suggest a better name for the option being discussed? Perhaps one of: --show-event-time --event-time ? Why not just --event-time? Really should have dropped

Re: [PATCH 3/3] perf report: Add --show-time-info option

2013-12-02 Thread David Ahern
On 12/2/13, 1:17 PM, Arnaldo Carvalho de Melo wrote: Probably, yeah, Ingo made some point about using --show- for some reason, Ingo? One I can think of is that, in general, plain --feature can mean, at least, one of --enable-feature and --show-feature, so perhaps that is the point. But then,

[PATCH 3/3] perf report: Add --show-time-info option

2013-12-01 Thread Namhyung Kim
From: Namhyung Kim The --show-time-info option is for displaying elapsed sampling time information for each entry. $ perf record -- perf bench sched messaging $ perf report --stdio --show-time-info ... # Samples: 10K of event 'cycles' # Event count (approx.): 5118793536 # Total

[PATCH 3/3] perf report: Add --show-time-info option

2013-12-01 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com The --show-time-info option is for displaying elapsed sampling time information for each entry. $ perf record -- perf bench sched messaging $ perf report --stdio --show-time-info ... # Samples: 10K of event 'cycles' # Event count (approx.):