Re: [PATCH 3/3] perf tools: Remove unnecessary callchain cursor state restore on unmatch

2014-01-14 Thread Namhyung Kim
On Tue, 14 Jan 2014 16:37:16 +0100, Frederic Weisbecker wrote: > If a new callchain branch doesn't match a single entry of the node that > it is given against comparison in append_chain(), then the cursor is > expected to be at the same position as it was before the comparison loop. > > As such,

[PATCH 3/3] perf tools: Remove unnecessary callchain cursor state restore on unmatch

2014-01-14 Thread Frederic Weisbecker
If a new callchain branch doesn't match a single entry of the node that it is given against comparison in append_chain(), then the cursor is expected to be at the same position as it was before the comparison loop. As such, there is no need to restore the cursor position on exit in case of non

[PATCH 3/3] perf tools: Remove unnecessary callchain cursor state restore on unmatch

2014-01-14 Thread Frederic Weisbecker
If a new callchain branch doesn't match a single entry of the node that it is given against comparison in append_chain(), then the cursor is expected to be at the same position as it was before the comparison loop. As such, there is no need to restore the cursor position on exit in case of non

Re: [PATCH 3/3] perf tools: Remove unnecessary callchain cursor state restore on unmatch

2014-01-14 Thread Namhyung Kim
On Tue, 14 Jan 2014 16:37:16 +0100, Frederic Weisbecker wrote: If a new callchain branch doesn't match a single entry of the node that it is given against comparison in append_chain(), then the cursor is expected to be at the same position as it was before the comparison loop. As such, there