Re: [PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver

2015-01-29 Thread Stanimir Varbanov
Hi Andy, On 01/29/2015 01:18 AM, Andy Gross wrote: > On Tue, Jan 20, 2015 at 11:17:56AM +0200, Stanimir Varbanov wrote: > > > >> +MSM_MUX_blsp1_spi, >> +MSM_MUX_blsp2_spi, >> +MSM_MUX_blsp3_spi, > > The above three need to be renamed to blsp_spiX_csX to denote which SPI and >

Re: [PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver

2015-01-29 Thread Stanimir Varbanov
Hi Andy, On 01/29/2015 01:18 AM, Andy Gross wrote: On Tue, Jan 20, 2015 at 11:17:56AM +0200, Stanimir Varbanov wrote: snip +MSM_MUX_blsp1_spi, +MSM_MUX_blsp2_spi, +MSM_MUX_blsp3_spi, The above three need to be renamed to blsp_spiX_csX to denote which SPI and chip select

Re: [PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver

2015-01-28 Thread Andy Gross
On Tue, Jan 20, 2015 at 11:17:56AM +0200, Stanimir Varbanov wrote: > + MSM_MUX_blsp1_spi, > + MSM_MUX_blsp2_spi, > + MSM_MUX_blsp3_spi, The above three need to be renamed to blsp_spiX_csX to denote which SPI and chip select they modify. > + MSM_MUX_blsp_i2c1, > +

Re: [PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver

2015-01-28 Thread Andy Gross
On Tue, Jan 20, 2015 at 11:17:56AM +0200, Stanimir Varbanov wrote: snip + MSM_MUX_blsp1_spi, + MSM_MUX_blsp2_spi, + MSM_MUX_blsp3_spi, The above three need to be renamed to blsp_spiX_csX to denote which SPI and chip select they modify. + MSM_MUX_blsp_i2c1, +

Re: [PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver

2015-01-27 Thread Bjorn
On Tue 20 Jan 01:17 PST 2015, Stanimir Varbanov wrote: > From: Joonwoo Park > > Add initial pinctrl driver to support pin configuration with > pinctrl framework for msm8916. > > Signed-off-by: Joonwoo Park > Signed-off-by: Stanimir Varbanov > --- [..] > + > +static const struct msm_pingroup

Re: [PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver

2015-01-27 Thread Bjorn
On Tue 20 Jan 01:17 PST 2015, Stanimir Varbanov wrote: From: Joonwoo Park joonw...@codeaurora.org Add initial pinctrl driver to support pin configuration with pinctrl framework for msm8916. Signed-off-by: Joonwoo Park joonw...@codeaurora.org Signed-off-by: Stanimir Varbanov

[PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver

2015-01-20 Thread Stanimir Varbanov
From: Joonwoo Park Add initial pinctrl driver to support pin configuration with pinctrl framework for msm8916. Signed-off-by: Joonwoo Park Signed-off-by: Stanimir Varbanov --- drivers/pinctrl/qcom/Kconfig |8 + drivers/pinctrl/qcom/Makefile |1 +

[PATCH 3/3] pinctrl: qcom: Add msm8916 pinctrl driver

2015-01-20 Thread Stanimir Varbanov
From: Joonwoo Park joonw...@codeaurora.org Add initial pinctrl driver to support pin configuration with pinctrl framework for msm8916. Signed-off-by: Joonwoo Park joonw...@codeaurora.org Signed-off-by: Stanimir Varbanov svarba...@mm-sol.com --- drivers/pinctrl/qcom/Kconfig |8 +