Re: [PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

2014-01-14 Thread Linus Walleij
On Thu, Jan 9, 2014 at 1:50 PM, Tomi Valkeinen wrote: > commit 4e7e8017a80e1 (pinctrl: pinctrl-single: > enhance to configure multiple pins of different modules) improved > support for pinctrl-single,bits option, but also caused a regression > in parsing badly configured mask data. > > If the

Re: [PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

2014-01-14 Thread Linus Walleij
On Thu, Jan 9, 2014 at 1:50 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: commit 4e7e8017a80e1 (pinctrl: pinctrl-single: enhance to configure multiple pins of different modules) improved support for pinctrl-single,bits option, but also caused a regression in parsing badly configured mask

[PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

2014-01-09 Thread Tomi Valkeinen
commit 4e7e8017a80e1 (pinctrl: pinctrl-single: enhance to configure multiple pins of different modules) improved support for pinctrl-single,bits option, but also caused a regression in parsing badly configured mask data. If the masks in DT data are not quite right,

[PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

2014-01-09 Thread Tomi Valkeinen
commit 4e7e8017a80e1 (pinctrl: pinctrl-single: enhance to configure multiple pins of different modules) improved support for pinctrl-single,bits option, but also caused a regression in parsing badly configured mask data. If the masks in DT data are not quite right,

Re: [PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

2013-11-30 Thread Tony Lindgren
* Tomi Valkeinen [131128 03:30]: > If the masks in DT data are not quite right, > pcs_parse_bits_in_pinctrl_entry() can end up in an infinite loop, > trashing memory at the same time. > > Add a check to verify that each loop actually removes bits from the > 'mask', so that the loop can

Re: [PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

2013-11-30 Thread Tony Lindgren
* Tomi Valkeinen tomi.valkei...@ti.com [131128 03:30]: If the masks in DT data are not quite right, pcs_parse_bits_in_pinctrl_entry() can end up in an infinite loop, trashing memory at the same time. Add a check to verify that each loop actually removes bits from the 'mask', so that the

[PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

2013-11-28 Thread Tomi Valkeinen
If the masks in DT data are not quite right, pcs_parse_bits_in_pinctrl_entry() can end up in an infinite loop, trashing memory at the same time. Add a check to verify that each loop actually removes bits from the 'mask', so that the loop can eventually end. Signed-off-by: Tomi Valkeinen ---

[PATCH 3/3] pinctrl: single: fix infinite loop caused by bad mask

2013-11-28 Thread Tomi Valkeinen
If the masks in DT data are not quite right, pcs_parse_bits_in_pinctrl_entry() can end up in an infinite loop, trashing memory at the same time. Add a check to verify that each loop actually removes bits from the 'mask', so that the loop can eventually end. Signed-off-by: Tomi Valkeinen