Re: [PATCH 3/3] regulator: mcp16502: add regulator driver for MCP16502

2018-11-23 Thread Mark Brown
On Wed, Nov 21, 2018 at 03:44:31PM +, andrei.stefane...@microchip.com wrote: > Thank you for your review. While working on the next version I realized that > the implementation should change a bit. The mcp16502 PMIC has separate > registers > for each of its operating modes (Performance,

Re: [PATCH 3/3] regulator: mcp16502: add regulator driver for MCP16502

2018-11-23 Thread Mark Brown
On Wed, Nov 21, 2018 at 03:44:31PM +, andrei.stefane...@microchip.com wrote: > Thank you for your review. While working on the next version I realized that > the implementation should change a bit. The mcp16502 PMIC has separate > registers > for each of its operating modes (Performance,

Re: [PATCH 3/3] regulator: mcp16502: add regulator driver for MCP16502

2018-11-21 Thread Andrei.Stefanescu
Hello Mark, Thank you for your review. While working on the next version I realized that the implementation should change a bit. The mcp16502 PMIC has separate registers for each of its operating modes (Performance, Active, Low-power, Hibernate). So, it is possible to setup the values for

Re: [PATCH 3/3] regulator: mcp16502: add regulator driver for MCP16502

2018-11-21 Thread Andrei.Stefanescu
Hello Mark, Thank you for your review. While working on the next version I realized that the implementation should change a bit. The mcp16502 PMIC has separate registers for each of its operating modes (Performance, Active, Low-power, Hibernate). So, it is possible to setup the values for

Re: [PATCH 3/3] regulator: mcp16502: add regulator driver for MCP16502

2018-11-13 Thread Mark Brown
On Tue, Nov 13, 2018 at 11:29:41AM +, andrei.stefane...@microchip.com wrote: > index 000..29c72d3 > --- /dev/null > +++ b/drivers/regulator/mcp16502.c > @@ -0,0 +1,524 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * MCP16502 PMIC driver Please make the entire comment a C++ comment

Re: [PATCH 3/3] regulator: mcp16502: add regulator driver for MCP16502

2018-11-13 Thread Mark Brown
On Tue, Nov 13, 2018 at 11:29:41AM +, andrei.stefane...@microchip.com wrote: > index 000..29c72d3 > --- /dev/null > +++ b/drivers/regulator/mcp16502.c > @@ -0,0 +1,524 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * MCP16502 PMIC driver Please make the entire comment a C++ comment

[PATCH 3/3] regulator: mcp16502: add regulator driver for MCP16502

2018-11-13 Thread Andrei.Stefanescu
This patch adds a regulator driver for the MCP16502 PMIC. This drivers supports basic operations through the regulator interface such as: - setting/reading voltage - setting/reading operating mode - reading current status - transitioning to/from suspend-to-ram and standby power states

[PATCH 3/3] regulator: mcp16502: add regulator driver for MCP16502

2018-11-13 Thread Andrei.Stefanescu
This patch adds a regulator driver for the MCP16502 PMIC. This drivers supports basic operations through the regulator interface such as: - setting/reading voltage - setting/reading operating mode - reading current status - transitioning to/from suspend-to-ram and standby power states