Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-17 Thread David Hildenbrand
On 17.12.20 12:45, Anshuman Khandual wrote: > > > On 12/10/20 12:34 PM, David Hildenbrand wrote: >> >>> Am 10.12.2020 um 07:58 schrieb Heiko Carstens : >>> >>> On Thu, Dec 10, 2020 at 09:48:11AM +0530, Anshuman Khandual wrote: >> Alternatively leaving __segment_load() and vmem_add_memory()

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-17 Thread Anshuman Khandual
On 12/10/20 12:34 PM, David Hildenbrand wrote: > >> Am 10.12.2020 um 07:58 schrieb Heiko Carstens : >> >> On Thu, Dec 10, 2020 at 09:48:11AM +0530, Anshuman Khandual wrote: > Alternatively leaving __segment_load() and vmem_add_memory() unchanged > will create three range checks i.e

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-10 Thread David Hildenbrand
On 10.12.20 09:58, Anshuman Khandual wrote: > > > On 12/10/20 1:32 PM, David Hildenbrand wrote: >> On 10.12.20 08:40, Anshuman Khandual wrote: >>> >>> >>> On 12/10/20 12:34 PM, David Hildenbrand wrote: > Am 10.12.2020 um 07:58 schrieb Heiko Carstens : > > On Thu, Dec 10, 2020

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-10 Thread Anshuman Khandual
On 12/10/20 1:32 PM, David Hildenbrand wrote: > On 10.12.20 08:40, Anshuman Khandual wrote: >> >> >> On 12/10/20 12:34 PM, David Hildenbrand wrote: >>> Am 10.12.2020 um 07:58 schrieb Heiko Carstens : On Thu, Dec 10, 2020 at 09:48:11AM +0530, Anshuman Khandual wrote: >>>

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-10 Thread David Hildenbrand
On 10.12.20 08:40, Anshuman Khandual wrote: > > > On 12/10/20 12:34 PM, David Hildenbrand wrote: >> >>> Am 10.12.2020 um 07:58 schrieb Heiko Carstens : >>> >>> On Thu, Dec 10, 2020 at 09:48:11AM +0530, Anshuman Khandual wrote: >> Alternatively leaving __segment_load() and vmem_add_memory()

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-09 Thread Anshuman Khandual
On 12/10/20 12:34 PM, David Hildenbrand wrote: > >> Am 10.12.2020 um 07:58 schrieb Heiko Carstens : >> >> On Thu, Dec 10, 2020 at 09:48:11AM +0530, Anshuman Khandual wrote: > Alternatively leaving __segment_load() and vmem_add_memory() unchanged > will create three range checks i.e

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-09 Thread David Hildenbrand
> Am 10.12.2020 um 07:58 schrieb Heiko Carstens : > > On Thu, Dec 10, 2020 at 09:48:11AM +0530, Anshuman Khandual wrote: Alternatively leaving __segment_load() and vmem_add_memory() unchanged will create three range checks i.e two memhp_range_allowed() and the existing

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-09 Thread Heiko Carstens
On Thu, Dec 10, 2020 at 09:48:11AM +0530, Anshuman Khandual wrote: > >> Alternatively leaving __segment_load() and vmem_add_memory() unchanged > >> will create three range checks i.e two memhp_range_allowed() and the > >> existing VMEM_MAX_PHYS check in vmem_add_mapping() on all the hotplug > >>

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-09 Thread Anshuman Khandual
On 12/9/20 8:27 PM, Heiko Carstens wrote: > On Wed, Dec 09, 2020 at 08:07:04AM +0530, Anshuman Khandual wrote: + if (seg->end + 1 > VMEM_MAX_PHYS || seg->end + 1 < seg->start_addr) { + rc = -ERANGE; + goto out_resource; + } + > ... +struct range

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-09 Thread Heiko Carstens
On Wed, Dec 09, 2020 at 08:07:04AM +0530, Anshuman Khandual wrote: > >> + if (seg->end + 1 > VMEM_MAX_PHYS || seg->end + 1 < seg->start_addr) { > >> + rc = -ERANGE; > >> + goto out_resource; > >> + } > >> + ... > >> +struct range arch_get_mappable_range(void) > >> +{ > >> +

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-08 Thread Anshuman Khandual
On 12/8/20 8:57 PM, Heiko Carstens wrote: > On Tue, Dec 08, 2020 at 09:46:18AM +0530, Anshuman Khandual wrote: >> This overrides arch_get_mappabble_range() on s390 platform which will be >> used with recently added generic framework. It drops a redundant similar >> check in vmem_add_mapping()

Re: [PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-08 Thread Heiko Carstens
On Tue, Dec 08, 2020 at 09:46:18AM +0530, Anshuman Khandual wrote: > This overrides arch_get_mappabble_range() on s390 platform which will be > used with recently added generic framework. It drops a redundant similar > check in vmem_add_mapping() while compensating __segment_load() with a new >

[PATCH 3/3] s390/mm: Define arch_get_mappable_range()

2020-12-07 Thread Anshuman Khandual
This overrides arch_get_mappabble_range() on s390 platform which will be used with recently added generic framework. It drops a redundant similar check in vmem_add_mapping() while compensating __segment_load() with a new address range check to preserve the existing functionality. It also adds a