Davidlohr Bueso wrote:
> On Fri, 2015-02-20 at 07:11 +0900, Tetsuo Handa wrote:
> > Davidlohr Bueso wrote:
> > > On Thu, 2015-02-19 at 20:07 +0900, Tetsuo Handa wrote:
> > > > Why do we need to let the caller call path_put() ?
> > > > There is no need to do like proc_exe_link() does, for
> > > >
Davidlohr Bueso wrote:
On Fri, 2015-02-20 at 07:11 +0900, Tetsuo Handa wrote:
Davidlohr Bueso wrote:
On Thu, 2015-02-19 at 20:07 +0900, Tetsuo Handa wrote:
Why do we need to let the caller call path_put() ?
There is no need to do like proc_exe_link() does, for
tomoyo_get_exe()
On Fri, 2015-02-20 at 08:28 -0800, Davidlohr Bueso wrote:
> 8<
> Subject: [PATCH v2 3/3] tomoyo: reduce mmap_sem hold for mm->exe_file
Tetsuo, could you please ack/nack this?
--
To unsubscribe from this list: send the line
On Fri, 2015-02-20 at 08:28 -0800, Davidlohr Bueso wrote:
8
Subject: [PATCH v2 3/3] tomoyo: reduce mmap_sem hold for mm-exe_file
Tetsuo, could you please ack/nack this?
--
To unsubscribe from this list: send the line
On Fri, 2015-02-20 at 07:11 +0900, Tetsuo Handa wrote:
> Davidlohr Bueso wrote:
> > On Thu, 2015-02-19 at 20:07 +0900, Tetsuo Handa wrote:
> > > Why do we need to let the caller call path_put() ?
> > > There is no need to do like proc_exe_link() does, for
> > > tomoyo_get_exe() returns pathname as
On Fri, 2015-02-20 at 07:11 +0900, Tetsuo Handa wrote:
Davidlohr Bueso wrote:
On Thu, 2015-02-19 at 20:07 +0900, Tetsuo Handa wrote:
Why do we need to let the caller call path_put() ?
There is no need to do like proc_exe_link() does, for
tomoyo_get_exe() returns pathname as char *.
Davidlohr Bueso wrote:
> On Thu, 2015-02-19 at 20:07 +0900, Tetsuo Handa wrote:
> > Why do we need to let the caller call path_put() ?
> > There is no need to do like proc_exe_link() does, for
> > tomoyo_get_exe() returns pathname as "char *".
>
> Having the pathname doesn't guarantee anything
On Thu, 2015-02-19 at 20:07 +0900, Tetsuo Handa wrote:
> Why do we need to let the caller call path_put() ?
> There is no need to do like proc_exe_link() does, for
> tomoyo_get_exe() returns pathname as "char *".
Having the pathname doesn't guarantee anything later, and thus doesn't
seem very
Thank you, but I think this patch is wrong and redundant.
Davidlohr Bueso wrote:
> On Wed, 2015-02-18 at 16:10 -0800, Davidlohr Bueso wrote:
> > +static const char *tomoyo_get_exe(struct mm_struct *mm)
> > +{
> > + struct file *exe_file;
> > + const char *cp = NULL;
> > +
> > + if (!mm)
> >
Thank you, but I think this patch is wrong and redundant.
Davidlohr Bueso wrote:
On Wed, 2015-02-18 at 16:10 -0800, Davidlohr Bueso wrote:
+static const char *tomoyo_get_exe(struct mm_struct *mm)
+{
+ struct file *exe_file;
+ const char *cp = NULL;
+
+ if (!mm)
+
On Thu, 2015-02-19 at 20:07 +0900, Tetsuo Handa wrote:
Why do we need to let the caller call path_put() ?
There is no need to do like proc_exe_link() does, for
tomoyo_get_exe() returns pathname as char *.
Having the pathname doesn't guarantee anything later, and thus doesn't
seem very robust
Davidlohr Bueso wrote:
On Thu, 2015-02-19 at 20:07 +0900, Tetsuo Handa wrote:
Why do we need to let the caller call path_put() ?
There is no need to do like proc_exe_link() does, for
tomoyo_get_exe() returns pathname as char *.
Having the pathname doesn't guarantee anything later, and
On Wed, 2015-02-18 at 16:10 -0800, Davidlohr Bueso wrote:
> +static const char *tomoyo_get_exe(struct mm_struct *mm)
> +{
> + struct file *exe_file;
> + const char *cp = NULL;
> +
> + if (!mm)
> + return NULL;
> + exe_file = get_mm_exe_file(mm);
> + if (!exe_file)
>
From: Davidlohr Bueso
The mm->exe_file is currently serialized with mmap_sem (shared)
in order to both safely (1) read the file and (2) compute the
realpath by calling tomoyo_realpath_from_path, making it an absolute
overkill. Good users will, on the other hand, make use of the more
standard
On Wed, 2015-02-18 at 16:10 -0800, Davidlohr Bueso wrote:
+static const char *tomoyo_get_exe(struct mm_struct *mm)
+{
+ struct file *exe_file;
+ const char *cp = NULL;
+
+ if (!mm)
+ return NULL;
+ exe_file = get_mm_exe_file(mm);
+ if (!exe_file)
+
From: Davidlohr Bueso d...@stgolabs.net
The mm-exe_file is currently serialized with mmap_sem (shared)
in order to both safely (1) read the file and (2) compute the
realpath by calling tomoyo_realpath_from_path, making it an absolute
overkill. Good users will, on the other hand, make use of the
16 matches
Mail list logo