Re: [PATCH 3/3] trace: print address if symbol not found

Hi Tobin, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc4 next-20171219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] trace: print address if symbol not found

Hi Tobin, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc4 next-20171219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] trace: print address if symbol not found

Hi Tobin, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc4 next-20171219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] trace: print address if symbol not found

Hi Tobin, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc4 next-20171219] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 10:37:38PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 14:00:11 +1100 > "Tobin C. Harding" wrote: > > > I ran through these as outlined here for the new version (v4). This hits > > the modified code but doesn't test symbol look up failure. > >

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 10:37:38PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 14:00:11 +1100 > "Tobin C. Harding" wrote: > > > I ran through these as outlined here for the new version (v4). This hits > > the modified code but doesn't test symbol look up failure. > > stacktrace shouldn't

Re: [PATCH 3/3] trace: print address if symbol not found

On Tue, 19 Dec 2017 14:00:11 +1100 "Tobin C. Harding" wrote: > I ran through these as outlined here for the new version (v4). This hits > the modified code but doesn't test symbol look up failure. stacktrace shouldn't post non kernel values, unless there's a frame pointer that

Re: [PATCH 3/3] trace: print address if symbol not found

On Tue, 19 Dec 2017 14:00:11 +1100 "Tobin C. Harding" wrote: > I ran through these as outlined here for the new version (v4). This hits > the modified code but doesn't test symbol look up failure. stacktrace shouldn't post non kernel values, unless there's a frame pointer that isn't handled by

Re: [PATCH 3/3] trace: print address if symbol not found

On Tue, Dec 19, 2017 at 02:00:11PM +1100, Tobin C. Harding wrote: > On Mon, Dec 18, 2017 at 06:51:43PM -0500, Steven Rostedt wrote: > > On Tue, 19 Dec 2017 08:16:14 +1100 > > "Tobin C. Harding" wrote: > > > > > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > > > diff --git

Re: [PATCH 3/3] trace: print address if symbol not found

On Tue, Dec 19, 2017 at 02:00:11PM +1100, Tobin C. Harding wrote: > On Mon, Dec 18, 2017 at 06:51:43PM -0500, Steven Rostedt wrote: > > On Tue, 19 Dec 2017 08:16:14 +1100 > > "Tobin C. Harding" wrote: > > > > > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > > > diff --git

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 06:51:43PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 08:16:14 +1100 > "Tobin C. Harding" wrote: > > > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > > diff --git a/kernel/trace/trace_events_hist.c > > > > b/kernel/trace/trace_events_hist.c > > > >

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 06:51:43PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 08:16:14 +1100 > "Tobin C. Harding" wrote: > > > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > > diff --git a/kernel/trace/trace_events_hist.c > > > > b/kernel/trace/trace_events_hist.c > > > > index

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 06:51:43PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 08:16:14 +1100 > "Tobin C. Harding" wrote: > > > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > > diff --git a/kernel/trace/trace_events_hist.c > > > > b/kernel/trace/trace_events_hist.c > > > >

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 06:51:43PM -0500, Steven Rostedt wrote: > On Tue, 19 Dec 2017 08:16:14 +1100 > "Tobin C. Harding" wrote: > > > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > > diff --git a/kernel/trace/trace_events_hist.c > > > > b/kernel/trace/trace_events_hist.c > > > > index

Re: [PATCH 3/3] trace: print address if symbol not found

On Tue, 19 Dec 2017 08:16:14 +1100 "Tobin C. Harding" wrote: > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > diff --git a/kernel/trace/trace_events_hist.c > > > b/kernel/trace/trace_events_hist.c > > > index 1e1558c99d56..3e28522a76f4 100644 > > > ---

Re: [PATCH 3/3] trace: print address if symbol not found

On Tue, 19 Dec 2017 08:16:14 +1100 "Tobin C. Harding" wrote: > > > #endif /* _LINUX_KERNEL_TRACE_H */ > > > diff --git a/kernel/trace/trace_events_hist.c > > > b/kernel/trace/trace_events_hist.c > > > index 1e1558c99d56..3e28522a76f4 100644 > > > --- a/kernel/trace/trace_events_hist.c > > >

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 11:49:47AM -0500, Steven Rostedt wrote: > On Mon, 18 Dec 2017 10:53:32 +1100 > "Tobin C. Harding" wrote: > > > Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak > > address when symbol not found") > > > > Previous patch changed

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 11:49:47AM -0500, Steven Rostedt wrote: > On Mon, 18 Dec 2017 10:53:32 +1100 > "Tobin C. Harding" wrote: > > > Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak > > address when symbol not found") > > > > Previous patch changed behaviour of kallsyms

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 11:49:47AM -0500, Steven Rostedt wrote: > On Mon, 18 Dec 2017 10:53:32 +1100 > "Tobin C. Harding" wrote: > > > Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak > > address when symbol not found") > > > > Previous patch changed

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, Dec 18, 2017 at 11:49:47AM -0500, Steven Rostedt wrote: > On Mon, 18 Dec 2017 10:53:32 +1100 > "Tobin C. Harding" wrote: > > > Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak > > address when symbol not found") > > > > Previous patch changed behaviour of kallsyms

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, 18 Dec 2017 10:53:32 +1100 "Tobin C. Harding" wrote: > Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak > address when symbol not found") > > Previous patch changed behaviour of kallsyms function sprint_symbol() to > return an error code instead of

Re: [PATCH 3/3] trace: print address if symbol not found

On Mon, 18 Dec 2017 10:53:32 +1100 "Tobin C. Harding" wrote: > Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak > address when symbol not found") > > Previous patch changed behaviour of kallsyms function sprint_symbol() to > return an error code instead of printing the

[PATCH 3/3] trace: print address if symbol not found

Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak address when symbol not found") Previous patch changed behaviour of kallsyms function sprint_symbol() to return an error code instead of printing the address if a symbol was not found. Ftrace relies on the original behaviour.

[PATCH 3/3] trace: print address if symbol not found

Fixes behaviour modified by: commit bd6b239cdbb2 ("kallsyms: don't leak address when symbol not found") Previous patch changed behaviour of kallsyms function sprint_symbol() to return an error code instead of printing the address if a symbol was not found. Ftrace relies on the original behaviour.