Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 08:11 PM, Roger Pau Monné wrote: > On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: >> >> On 07/25/2016 06:53 PM, Roger Pau Monné wrote: >> ..[snip..] >> * We get the device lock and blk_mq_freeze_queue() in >> dynamic_reconfig_device(), >>and then have to

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 08:11 PM, Roger Pau Monné wrote: > On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: >> >> On 07/25/2016 06:53 PM, Roger Pau Monné wrote: >> ..[snip..] >> * We get the device lock and blk_mq_freeze_queue() in >> dynamic_reconfig_device(), >>and then have to

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Roger Pau Monné
On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: > > On 07/25/2016 06:53 PM, Roger Pau Monné wrote: > ..[snip..] > * We get the device lock and blk_mq_freeze_queue() in > dynamic_reconfig_device(), > and then have to release in blkif_recover() asynchronously which >

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Roger Pau Monné
On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote: > > On 07/25/2016 06:53 PM, Roger Pau Monné wrote: > ..[snip..] > * We get the device lock and blk_mq_freeze_queue() in > dynamic_reconfig_device(), > and then have to release in blkif_recover() asynchronously which >

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 06:53 PM, Roger Pau Monné wrote: ..[snip..] * We get the device lock and blk_mq_freeze_queue() in dynamic_reconfig_device(), and then have to release in blkif_recover() asynchronously which makes the code more difficult to readable. >>> >>> I'm not sure I'm

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 06:53 PM, Roger Pau Monné wrote: ..[snip..] * We get the device lock and blk_mq_freeze_queue() in dynamic_reconfig_device(), and then have to release in blkif_recover() asynchronously which makes the code more difficult to readable. >>> >>> I'm not sure I'm

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Roger Pau Monné
On Mon, Jul 25, 2016 at 06:29:22PM +0800, Bob Liu wrote: > > On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > >

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Roger Pau Monné
On Mon, Jul 25, 2016 at 06:29:22PM +0800, Bob Liu wrote: > > On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > >

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: >> >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > On Fri, Jul

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Bob Liu
On 07/25/2016 05:20 PM, Roger Pau Monné wrote: > On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: >> >> On 07/22/2016 07:45 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > On Fri, Jul

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Roger Pau Monné
On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > > On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > >

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-25 Thread Roger Pau Monné
On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote: > > On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > >>> On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > >

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: >> >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > On Thu, Jul

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 07:45 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: >> >> On 07/22/2016 05:34 PM, Roger Pau Monné wrote: >>> On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > On Thu, Jul

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Roger Pau Monné
On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > > On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > >>> On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > >

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Roger Pau Monné
On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote: > > On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > >> > >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > >>> On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > >

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: >> >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote: >>> On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: On 07/21/2016 04:57 PM, Roger Pau Monné wrote: >> ..[snip].. >>

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 05:34 PM, Roger Pau Monné wrote: > On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: >> >> On 07/22/2016 03:45 PM, Roger Pau Monné wrote: >>> On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: On 07/21/2016 04:57 PM, Roger Pau Monné wrote: >> ..[snip].. >>

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Roger Pau Monné
On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > > On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > >> > >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > ..[snip].. > + > +static ssize_t

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Roger Pau Monné
On Fri, Jul 22, 2016 at 04:17:48PM +0800, Bob Liu wrote: > > On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > >> > >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > ..[snip].. > + > +static ssize_t

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: >> >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote: ..[snip].. + +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t count) +{ + unsigned

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Bob Liu
On 07/22/2016 03:45 PM, Roger Pau Monné wrote: > On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: >> >> On 07/21/2016 04:57 PM, Roger Pau Monné wrote: ..[snip].. + +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t count) +{ + unsigned

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Roger Pau Monné
On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > > On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: > >> The current VBD layer reserves buffer space for each attached device based > >> on > >> three statically configured

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-22 Thread Roger Pau Monné
On Thu, Jul 21, 2016 at 06:08:05PM +0800, Bob Liu wrote: > > On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: > >> The current VBD layer reserves buffer space for each attached device based > >> on > >> three statically configured

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-21 Thread Bob Liu
On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: >> The current VBD layer reserves buffer space for each attached device based on >> three statically configured settings which are read at boot time. >> * max_indirect_segs: Maximum amount

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-21 Thread Bob Liu
On 07/21/2016 04:57 PM, Roger Pau Monné wrote: > On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: >> The current VBD layer reserves buffer space for each attached device based on >> three statically configured settings which are read at boot time. >> * max_indirect_segs: Maximum amount

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-21 Thread Roger Pau Monné
On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > * max_ring_page_order: Maximum order

Re: [PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-21 Thread Roger Pau Monné
On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote: > The current VBD layer reserves buffer space for each attached device based on > three statically configured settings which are read at boot time. > * max_indirect_segs: Maximum amount of segments. > * max_ring_page_order: Maximum order

[PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-15 Thread Bob Liu
The current VBD layer reserves buffer space for each attached device based on three statically configured settings which are read at boot time. * max_indirect_segs: Maximum amount of segments. * max_ring_page_order: Maximum order of pages to be used for the shared ring. * max_queues: Maximum of

[PATCH 3/3] xen-blkfront: dynamic configuration of per-vbd resources

2016-07-15 Thread Bob Liu
The current VBD layer reserves buffer space for each attached device based on three statically configured settings which are read at boot time. * max_indirect_segs: Maximum amount of segments. * max_ring_page_order: Maximum order of pages to be used for the shared ring. * max_queues: Maximum of