Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-15 Thread Sergey Senozhatsky
On (01/15/14 13:24), Minchan Kim wrote: > Hello Sergey, > > On Tue, Jan 14, 2014 at 12:37:40PM +0300, Sergey Senozhatsky wrote: > > 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats > > `show' functions and reduce code duplication. > > > > 2) Account and report back to user

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-15 Thread Sergey Senozhatsky
On (01/15/14 13:24), Minchan Kim wrote: Hello Sergey, On Tue, Jan 14, 2014 at 12:37:40PM +0300, Sergey Senozhatsky wrote: 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show' functions and reduce code duplication. 2) Account and report back to user numbers of

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Minchan Kim
Hello Sergey, On Tue, Jan 14, 2014 at 12:37:40PM +0300, Sergey Senozhatsky wrote: > 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats > `show' functions and reduce code duplication. > > 2) Account and report back to user numbers of failed READ and WRITE > operations. > > 3)

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 03:09 PM, Sergey Senozhatsky wrote: > On (01/14/14 15:02), Jerome Marchand wrote: >> On 01/14/2014 02:53 PM, Sergey Senozhatsky wrote: >>> On (01/14/14 14:43), Jerome Marchand wrote: >>> [..] >> >> That's weird: good/bad_compress are accounted, but it seems to me that >>

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
On (01/14/14 15:02), Jerome Marchand wrote: > On 01/14/2014 02:53 PM, Sergey Senozhatsky wrote: > > On (01/14/14 14:43), Jerome Marchand wrote: > > [..] > > That's weird: good/bad_compress are accounted, but it seems to me that > they are to never used in any way. If so, there is

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 02:53 PM, Sergey Senozhatsky wrote: > On (01/14/14 14:43), Jerome Marchand wrote: > [..] That's weird: good/bad_compress are accounted, but it seems to me that they are to never used in any way. If so, there is indeed no reason to keep them. >

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
On (01/14/14 14:43), Jerome Marchand wrote: [..] > >> > >> That's weird: good/bad_compress are accounted, but it seems to me that > >> they are to never used in any way. If so, there is indeed no reason to > >> keep them. > >> > >> > >>> Account each sub-request > >>> compression size so we can

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 12:10 PM, Sergey Senozhatsky wrote: > On (01/14/14 11:38), Jerome Marchand wrote: >> On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: >>> 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats >>> `show' functions and reduce code duplication. >>> >>> 2) Account and report

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
On (01/14/14 13:15), Jerome Marchand wrote: > On 01/14/2014 11:57 AM, Sergey Senozhatsky wrote: > > > > Hello Jerome, > > > > On (01/14/14 11:38), Jerome Marchand wrote: > >> On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: > >>> 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 11:57 AM, Sergey Senozhatsky wrote: > > Hello Jerome, > > On (01/14/14 11:38), Jerome Marchand wrote: >> On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: >>> 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats >>> `show' functions and reduce code duplication. >>> >>>

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
On (01/14/14 11:38), Jerome Marchand wrote: > On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: > > 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats > > `show' functions and reduce code duplication. > > > > 2) Account and report back to user numbers of failed READ and WRITE > >

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
Hello Jerome, On (01/14/14 11:38), Jerome Marchand wrote: > On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: > > 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats > > `show' functions and reduce code duplication. > > > > 2) Account and report back to user numbers of failed READ

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: > 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats > `show' functions and reduce code duplication. > > 2) Account and report back to user numbers of failed READ and WRITE > operations. > > 3) Remove `good' and `bad' compressed

[PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show' functions and reduce code duplication. 2) Account and report back to user numbers of failed READ and WRITE operations. 3) Remove `good' and `bad' compressed sub-requests stats. RW request may cause a number of RW

[PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show' functions and reduce code duplication. 2) Account and report back to user numbers of failed READ and WRITE operations. 3) Remove `good' and `bad' compressed sub-requests stats. RW request may cause a number of RW

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show' functions and reduce code duplication. 2) Account and report back to user numbers of failed READ and WRITE operations. 3) Remove `good' and `bad' compressed

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
Hello Jerome, On (01/14/14 11:38), Jerome Marchand wrote: On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show' functions and reduce code duplication. 2) Account and report back to user numbers of failed READ and

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
On (01/14/14 11:38), Jerome Marchand wrote: On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show' functions and reduce code duplication. 2) Account and report back to user numbers of failed READ and WRITE operations.

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 11:57 AM, Sergey Senozhatsky wrote: Hello Jerome, On (01/14/14 11:38), Jerome Marchand wrote: On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show' functions and reduce code duplication. 2) Account and

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
On (01/14/14 13:15), Jerome Marchand wrote: On 01/14/2014 11:57 AM, Sergey Senozhatsky wrote: Hello Jerome, On (01/14/14 11:38), Jerome Marchand wrote: On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show'

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 12:10 PM, Sergey Senozhatsky wrote: On (01/14/14 11:38), Jerome Marchand wrote: On 01/14/2014 10:37 AM, Sergey Senozhatsky wrote: 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show' functions and reduce code duplication. 2) Account and report back to user

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
On (01/14/14 14:43), Jerome Marchand wrote: [..] That's weird: good/bad_compress are accounted, but it seems to me that they are to never used in any way. If so, there is indeed no reason to keep them. Account each sub-request compression size so we can calculate real device

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 02:53 PM, Sergey Senozhatsky wrote: On (01/14/14 14:43), Jerome Marchand wrote: [..] That's weird: good/bad_compress are accounted, but it seems to me that they are to never used in any way. If so, there is indeed no reason to keep them. Account each sub-request compression

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Sergey Senozhatsky
On (01/14/14 15:02), Jerome Marchand wrote: On 01/14/2014 02:53 PM, Sergey Senozhatsky wrote: On (01/14/14 14:43), Jerome Marchand wrote: [..] That's weird: good/bad_compress are accounted, but it seems to me that they are to never used in any way. If so, there is indeed no reason to

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Jerome Marchand
On 01/14/2014 03:09 PM, Sergey Senozhatsky wrote: On (01/14/14 15:02), Jerome Marchand wrote: On 01/14/2014 02:53 PM, Sergey Senozhatsky wrote: On (01/14/14 14:43), Jerome Marchand wrote: [..] That's weird: good/bad_compress are accounted, but it seems to me that they are to never used in

Re: [PATCH 3/3] zram: rework reported to end-user zram statistics

2014-01-14 Thread Minchan Kim
Hello Sergey, On Tue, Jan 14, 2014 at 12:37:40PM +0300, Sergey Senozhatsky wrote: 1) Introduce ZRAM_ATTR_RO macro to generate zram atomic64_t stats `show' functions and reduce code duplication. 2) Account and report back to user numbers of failed READ and WRITE operations. 3) Remove