Re: [PATCH 3/3 v2] sched/fair: reduce cases for active balance

2021-01-12 Thread Mel Gorman
On Thu, Jan 07, 2021 at 11:33:25AM +0100, Vincent Guittot wrote: > Active balance is triggered for a number of voluntary cases like misfit > or pinned tasks cases but also after that a number of load balance > attempts failed to migrate a task. There is no need to use active load > balance when

Re: [PATCH 3/3 v2] sched/fair: reduce cases for active balance

2021-01-08 Thread Valentin Schneider
On 08/01/21 09:11, Vincent Guittot wrote: > On Thu, 7 Jan 2021 at 18:40, Valentin Schneider > wrote: >> >> On 07/01/21 13:20, Vincent Guittot wrote: >> > On Thu, 7 Jan 2021 at 12:26, Valentin Schneider >> > wrote: >> >> > @@ -9499,13 +9499,32 @@ asym_active_balance(struct lb_env *env) >> >> > }

Re: [PATCH 3/3 v2] sched/fair: reduce cases for active balance

2021-01-08 Thread Vincent Guittot
On Thu, 7 Jan 2021 at 18:40, Valentin Schneider wrote: > > On 07/01/21 13:20, Vincent Guittot wrote: > > On Thu, 7 Jan 2021 at 12:26, Valentin Schneider > > wrote: > >> > @@ -9499,13 +9499,32 @@ asym_active_balance(struct lb_env *env) > >> > } > >> > > >> > static inline bool > >> >

Re: [PATCH 3/3 v2] sched/fair: reduce cases for active balance

2021-01-07 Thread Valentin Schneider
On 07/01/21 13:20, Vincent Guittot wrote: > On Thu, 7 Jan 2021 at 12:26, Valentin Schneider > wrote: >> > @@ -9499,13 +9499,32 @@ asym_active_balance(struct lb_env *env) >> > } >> > >> > static inline bool >> > -voluntary_active_balance(struct lb_env *env) >> > +imbalanced_active_balance(struct

Re: [PATCH 3/3 v2] sched/fair: reduce cases for active balance

2021-01-07 Thread Vincent Guittot
On Thu, 7 Jan 2021 at 12:26, Valentin Schneider wrote: > > On 07/01/21 11:33, Vincent Guittot wrote: > > Active balance is triggered for a number of voluntary cases like misfit > > or pinned tasks cases but also after that a number of load balance > > attempts failed to migrate a task. There is

Re: [PATCH 3/3 v2] sched/fair: reduce cases for active balance

2021-01-07 Thread Valentin Schneider
On 07/01/21 11:33, Vincent Guittot wrote: > Active balance is triggered for a number of voluntary cases like misfit > or pinned tasks cases but also after that a number of load balance > attempts failed to migrate a task. There is no need to use active load > balance when the group is overloaded

[PATCH 3/3 v2] sched/fair: reduce cases for active balance

2021-01-07 Thread Vincent Guittot
Active balance is triggered for a number of voluntary cases like misfit or pinned tasks cases but also after that a number of load balance attempts failed to migrate a task. There is no need to use active load balance when the group is overloaded because an overloaded state means that there is at