RE: [PATCH 3/3 v3] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.

2012-10-23 Thread Sethi Varun-B16395
Subject: Re: [PATCH 3/3 v3] iommu/fsl: Freescale PAMU driver and IOMMU > API implementation. > > On 10/22/2012 04:18:07 PM, Tabi Timur-B04825 wrote: > > On Wed, Oct 17, 2012 at 12:32 PM, Varun Sethi > > wrote: > > > +} > > > + > > > +static unsig

RE: [PATCH 3/3 v3] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.

2012-10-23 Thread Sethi Varun-B16395
TCH 3/3 v3] iommu/fsl: Freescale PAMU driver and IOMMU > API implementation. > > On Wed, Oct 17, 2012 at 12:32 PM, Varun Sethi > wrote: > > > + * Copyright (C) 2012 Freescale Semiconductor, Inc. > > Copyright 2012 Freescale Semiconductor, Inc. > [Sethi Varun-B16395] Have

Re: [PATCH 3/3 v3] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.

2012-10-22 Thread Scott Wood
On 10/22/2012 04:18:07 PM, Tabi Timur-B04825 wrote: On Wed, Oct 17, 2012 at 12:32 PM, Varun Sethi wrote: > +} > + > +static unsigned long pamu_get_fspi_and_allocate(u32 subwin_cnt) > +{ subwin_cnt should probably be an unsigned int. This function needs to be documented. What value is being

Re: [PATCH 3/3 v3] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.

2012-10-22 Thread Tabi Timur-B04825
On Wed, Oct 17, 2012 at 12:32 PM, Varun Sethi wrote: > + * Copyright (C) 2012 Freescale Semiconductor, Inc. Copyright 2012 Freescale Semiconductor, Inc. > + * > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#incl