Re: [PATCH 3/4] Export blk_fill_rwbs()

2013-01-31 Thread Steven Rostedt
On Fri, 2013-02-01 at 11:57 +0800, Li Zefan wrote: > on 2013/2/1 11:48, Steven Rostedt wrote: > > Li, > > > > Can you give an Ack or Nack for this. > > > > I think this patch shouldn't go into upstream without bcache code. We don't > export symbols for out of tree code. > Even for GPL code? I

Re: [PATCH 3/4] Export blk_fill_rwbs()

2013-01-31 Thread Li Zefan
on 2013/2/1 11:48, Steven Rostedt wrote: > Li, > > Can you give an Ack or Nack for this. > I think this patch shouldn't go into upstream without bcache code. We don't export symbols for out of tree code. > Thanks, > > -- Steve > > > On Tue, 2013-01-15 at 13:25 -0800, Kent Overstreet wrote:

Re: [PATCH 3/4] Export blk_fill_rwbs()

2013-01-31 Thread Steven Rostedt
Li, Can you give an Ack or Nack for this. Thanks, -- Steve On Tue, 2013-01-15 at 13:25 -0800, Kent Overstreet wrote: > Exported so it can be used by bcache's tracepoints > > Signed-off-by: Kent Overstreet > CC: Steven Rostedt > CC: Frederic Weisbecker > CC: Ingo Molnar > --- >

Re: [PATCH 3/4] Export blk_fill_rwbs()

2013-01-31 Thread Steven Rostedt
Li, Can you give an Ack or Nack for this. Thanks, -- Steve On Tue, 2013-01-15 at 13:25 -0800, Kent Overstreet wrote: Exported so it can be used by bcache's tracepoints Signed-off-by: Kent Overstreet koverstr...@google.com CC: Steven Rostedt rost...@goodmis.org CC: Frederic Weisbecker

Re: [PATCH 3/4] Export blk_fill_rwbs()

2013-01-31 Thread Li Zefan
on 2013/2/1 11:48, Steven Rostedt wrote: Li, Can you give an Ack or Nack for this. I think this patch shouldn't go into upstream without bcache code. We don't export symbols for out of tree code. Thanks, -- Steve On Tue, 2013-01-15 at 13:25 -0800, Kent Overstreet wrote: Exported

Re: [PATCH 3/4] Export blk_fill_rwbs()

2013-01-31 Thread Steven Rostedt
On Fri, 2013-02-01 at 11:57 +0800, Li Zefan wrote: on 2013/2/1 11:48, Steven Rostedt wrote: Li, Can you give an Ack or Nack for this. I think this patch shouldn't go into upstream without bcache code. We don't export symbols for out of tree code. Even for GPL code? I have no

[PATCH 3/4] Export blk_fill_rwbs()

2013-01-15 Thread Kent Overstreet
Exported so it can be used by bcache's tracepoints Signed-off-by: Kent Overstreet CC: Steven Rostedt CC: Frederic Weisbecker CC: Ingo Molnar --- kernel/trace/blktrace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c index

[PATCH 3/4] Export blk_fill_rwbs()

2013-01-15 Thread Kent Overstreet
Exported so it can be used by bcache's tracepoints Signed-off-by: Kent Overstreet koverstr...@google.com CC: Steven Rostedt rost...@goodmis.org CC: Frederic Weisbecker fweis...@gmail.com CC: Ingo Molnar mi...@redhat.com --- kernel/trace/blktrace.c | 1 + 1 file changed, 1 insertion(+) diff