Re: [PATCH 3/4] brd: Fix all partitions BUGs

2014-08-07 Thread Ross Zwisler
On Wed, 2014-08-06 at 14:33 +0300, Boaz Harrosh wrote: > This patch fixes up brd's partitions scheme, now enjoying all worlds. > > The MAIN fix here is that currently if one fdisks some partitions, > a BAD bug will make all partitions point to the same start-end sector > ie: 0 - brd_size And an

Re: [PATCH 3/4] brd: Fix all partitions BUGs

2014-08-07 Thread Ross Zwisler
On Thu, 2014-08-07 at 12:11 +0300, Boaz Harrosh wrote: > On 08/07/2014 02:06 AM, Ross Zwisler wrote: > > Also, it looks like you can still create a new device with this patch, but > > you > > can't create partitions on that device. Not sure if this is just what you > > get > > when you

Re: [PATCH 3/4] brd: Fix all partitions BUGs

2014-08-07 Thread Boaz Harrosh
On 08/07/2014 02:06 AM, Ross Zwisler wrote: > On Wed, 2014-08-06 at 14:33 +0300, Boaz Harrosh wrote: > > With this patch we end up in what feels like a weird place where we're half > using the old scheme of major/minor allocation, and half in the world of > dynamic major/minors. Devices have a

Re: [PATCH 3/4] brd: Fix all partitions BUGs

2014-08-07 Thread Boaz Harrosh
On 08/07/2014 02:06 AM, Ross Zwisler wrote: On Wed, 2014-08-06 at 14:33 +0300, Boaz Harrosh wrote: With this patch we end up in what feels like a weird place where we're half using the old scheme of major/minor allocation, and half in the world of dynamic major/minors. Devices have a major

Re: [PATCH 3/4] brd: Fix all partitions BUGs

2014-08-07 Thread Ross Zwisler
On Thu, 2014-08-07 at 12:11 +0300, Boaz Harrosh wrote: On 08/07/2014 02:06 AM, Ross Zwisler wrote: Also, it looks like you can still create a new device with this patch, but you can't create partitions on that device. Not sure if this is just what you get when you dynamically create

Re: [PATCH 3/4] brd: Fix all partitions BUGs

2014-08-07 Thread Ross Zwisler
On Wed, 2014-08-06 at 14:33 +0300, Boaz Harrosh wrote: This patch fixes up brd's partitions scheme, now enjoying all worlds. The MAIN fix here is that currently if one fdisks some partitions, a BAD bug will make all partitions point to the same start-end sector ie: 0 - brd_size And an mkfs

Re: [PATCH 3/4] brd: Fix all partitions BUGs

2014-08-06 Thread Ross Zwisler
On Wed, 2014-08-06 at 14:33 +0300, Boaz Harrosh wrote: > This patch fixes up brd's partitions scheme, now enjoying all worlds. > > The MAIN fix here is that currently if one fdisks some partitions, > a BAD bug will make all partitions point to the same start-end sector > ie: 0 - brd_size And an

[PATCH 3/4] brd: Fix all partitions BUGs

2014-08-06 Thread Boaz Harrosh
This patch fixes up brd's partitions scheme, now enjoying all worlds. The MAIN fix here is that currently if one fdisks some partitions, a BAD bug will make all partitions point to the same start-end sector ie: 0 - brd_size And an mkfs of any partition would trash the partition table and the

[PATCH 3/4] brd: Fix all partitions BUGs

2014-08-06 Thread Boaz Harrosh
This patch fixes up brd's partitions scheme, now enjoying all worlds. The MAIN fix here is that currently if one fdisks some partitions, a BAD bug will make all partitions point to the same start-end sector ie: 0 - brd_size And an mkfs of any partition would trash the partition table and the

Re: [PATCH 3/4] brd: Fix all partitions BUGs

2014-08-06 Thread Ross Zwisler
On Wed, 2014-08-06 at 14:33 +0300, Boaz Harrosh wrote: This patch fixes up brd's partitions scheme, now enjoying all worlds. The MAIN fix here is that currently if one fdisks some partitions, a BAD bug will make all partitions point to the same start-end sector ie: 0 - brd_size And an mkfs