Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-10 Thread Daniel Vetter
On Tue, May 10, 2016 at 8:59 AM, Daniel Vetter wrote: >> if (ret) >> return ret; >> >> /* How to handle !visible, is it even possible? */ > > if (!visible) > return -EINVAL; > > You can't, so need to reject it. Ok, on further thought I

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-10 Thread Daniel Vetter
On Tue, May 10, 2016 at 8:59 AM, Daniel Vetter wrote: >> if (ret) >> return ret; >> >> /* How to handle !visible, is it even possible? */ > > if (!visible) > return -EINVAL; > > You can't, so need to reject it. Ok, on further thought I think we need a bit

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-10 Thread Daniel Vetter
On Mon, May 09, 2016 at 08:37:39PM +0200, Noralf Trønnes wrote: > > Den 09.05.2016 16:46, skrev Daniel Vetter: > >On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: > >>Provides helper functions for drivers that have a simple display > >>pipeline. Plane, crtc and encoder are

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-10 Thread Daniel Vetter
On Mon, May 09, 2016 at 08:37:39PM +0200, Noralf Trønnes wrote: > > Den 09.05.2016 16:46, skrev Daniel Vetter: > >On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: > >>Provides helper functions for drivers that have a simple display > >>pipeline. Plane, crtc and encoder are

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-09 Thread Noralf Trønnes
Den 09.05.2016 16:46, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-09 Thread Noralf Trønnes
Den 09.05.2016 16:46, skrev Daniel Vetter: On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes +static int

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-09 Thread Daniel Vetter
On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: > Provides helper functions for drivers that have a simple display > pipeline. Plane, crtc and encoder are collapsed into one entity. > > Signed-off-by: Noralf Trønnes > +static int

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-09 Thread Daniel Vetter
On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: > Provides helper functions for drivers that have a simple display > pipeline. Plane, crtc and encoder are collapsed into one entity. > > Signed-off-by: Noralf Trønnes > +static int drm_simple_kms_plane_atomic_check(struct

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-05 Thread Daniel Vetter
On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: > Provides helper functions for drivers that have a simple display > pipeline. Plane, crtc and encoder are collapsed into one entity. > > Signed-off-by: Noralf Trønnes When resubmitting a patch please always

Re: [PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-05 Thread Daniel Vetter
On Thu, May 05, 2016 at 03:24:33PM +0200, Noralf Trønnes wrote: > Provides helper functions for drivers that have a simple display > pipeline. Plane, crtc and encoder are collapsed into one entity. > > Signed-off-by: Noralf Trønnes When resubmitting a patch please always have a per-patch

[PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-05 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 7 ++ drivers/gpu/drm/Makefile| 1 +

[PATCH 3/4] drm: Add helper for simple display pipeline

2016-05-05 Thread Noralf Trønnes
Provides helper functions for drivers that have a simple display pipeline. Plane, crtc and encoder are collapsed into one entity. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/Kconfig | 7 ++ drivers/gpu/drm/Makefile| 1 +