Re: [PATCH 3/4] leds: Add LED support for MT6323 PMIC

2017-01-28 Thread Sean Wang
Hi Jacek, thanks for your effort on reviewing I has given these idea about your questions inline below and will fix up these explicit mistakes in the next version. thanks again On Tue, 2017-01-24 at 23:51 +0100, Jacek Anaszewski wrote: > Hi Sean, > > Thanks for the patch. Please find my

Re: [PATCH 3/4] leds: Add LED support for MT6323 PMIC

2017-01-28 Thread Sean Wang
Hi Jacek, thanks for your effort on reviewing I has given these idea about your questions inline below and will fix up these explicit mistakes in the next version. thanks again On Tue, 2017-01-24 at 23:51 +0100, Jacek Anaszewski wrote: > Hi Sean, > > Thanks for the patch. Please find my

Re: [PATCH 3/4] leds: Add LED support for MT6323 PMIC

2017-01-24 Thread Jacek Anaszewski
Hi Sean, Thanks for the patch. Please find my comments in the code below. On 01/23/2017 04:54 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > MT6323 PMIC is a multi-function device that includes > LED function. It allows attaching upto 4 LEDs which can

Re: [PATCH 3/4] leds: Add LED support for MT6323 PMIC

2017-01-24 Thread Jacek Anaszewski
Hi Sean, Thanks for the patch. Please find my comments in the code below. On 01/23/2017 04:54 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > MT6323 PMIC is a multi-function device that includes > LED function. It allows attaching upto 4 LEDs which can s/upto/up to/ > either be on,

[PATCH 3/4] leds: Add LED support for MT6323 PMIC

2017-01-22 Thread sean.wang
From: Sean Wang MT6323 PMIC is a multi-function device that includes LED function. It allows attaching upto 4 LEDs which can either be on, off or dimmed and/or blinked with the the controller. Signed-off-by: Sean Wang --- drivers/leds/Kconfig

[PATCH 3/4] leds: Add LED support for MT6323 PMIC

2017-01-22 Thread sean.wang
From: Sean Wang MT6323 PMIC is a multi-function device that includes LED function. It allows attaching upto 4 LEDs which can either be on, off or dimmed and/or blinked with the the controller. Signed-off-by: Sean Wang --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 +