Re: [PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-22 Thread Mel Gorman
On Thu, Nov 22, 2018 at 04:35:58PM +0100, Vlastimil Babka wrote: > >> I think I don't understand this comment :( Do you want to avoid waking > >> up kswapd from steal_suitable_fallback() (introduced above) for > >> allocations without __GFP_KSWAPD_RECLAIM? But returning 0 here means > >> actually

Re: [PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-22 Thread Mel Gorman
On Thu, Nov 22, 2018 at 04:35:58PM +0100, Vlastimil Babka wrote: > >> I think I don't understand this comment :( Do you want to avoid waking > >> up kswapd from steal_suitable_fallback() (introduced above) for > >> allocations without __GFP_KSWAPD_RECLAIM? But returning 0 here means > >> actually

Re: [PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-22 Thread Vlastimil Babka
On 11/22/18 4:04 PM, Mel Gorman wrote: > On Thu, Nov 22, 2018 at 02:53:08PM +0100, Vlastimil Babka wrote: >> >> So the reason I was wondering about movable vs unmovable fallbacks here >> is that movable fallbacks are ok as they can be migrated later, but the >> unmovable/reclaimable not, which is

Re: [PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-22 Thread Vlastimil Babka
On 11/22/18 4:04 PM, Mel Gorman wrote: > On Thu, Nov 22, 2018 at 02:53:08PM +0100, Vlastimil Babka wrote: >> >> So the reason I was wondering about movable vs unmovable fallbacks here >> is that movable fallbacks are ok as they can be migrated later, but the >> unmovable/reclaimable not, which is

Re: [PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-22 Thread Mel Gorman
On Thu, Nov 22, 2018 at 02:53:08PM +0100, Vlastimil Babka wrote: > > 1-socket Skylake machine > > config-global-dhp__workload_thpfioscale XFS (no special madvise) > > 4 fio threads, 1 THP allocating thread > > -- > > > > 4.20-rc1 extfrag events < order 9:

Re: [PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-22 Thread Mel Gorman
On Thu, Nov 22, 2018 at 02:53:08PM +0100, Vlastimil Babka wrote: > > 1-socket Skylake machine > > config-global-dhp__workload_thpfioscale XFS (no special madvise) > > 4 fio threads, 1 THP allocating thread > > -- > > > > 4.20-rc1 extfrag events < order 9:

Re: [PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-22 Thread Vlastimil Babka
On 11/21/18 11:14 AM, Mel Gorman wrote: > An external fragmentation event was previously described as > > When the page allocator fragments memory, it records the event using > the mm_page_alloc_extfrag event. If the fallback_order is smaller > than a pageblock order (order-9 on

Re: [PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-22 Thread Vlastimil Babka
On 11/21/18 11:14 AM, Mel Gorman wrote: > An external fragmentation event was previously described as > > When the page allocator fragments memory, it records the event using > the mm_page_alloc_extfrag event. If the fallback_order is smaller > than a pageblock order (order-9 on

[PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-21 Thread Mel Gorman
An external fragmentation event was previously described as When the page allocator fragments memory, it records the event using the mm_page_alloc_extfrag event. If the fallback_order is smaller than a pageblock order (order-9 on 64-bit x86) then it's considered an event that will

[PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-21 Thread Mel Gorman
An external fragmentation event was previously described as When the page allocator fragments memory, it records the event using the mm_page_alloc_extfrag event. If the fallback_order is smaller than a pageblock order (order-9 on 64-bit x86) then it's considered an event that will

[PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-08 Thread Mel Gorman
An external fragmentation event was previously described as When the page allocator fragments memory, it records the event using the mm_page_alloc_extfrag event. If the fallback_order is smaller than a pageblock order (order-9 on 64-bit x86) then it's considered an event that will

[PATCH 3/4] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-08 Thread Mel Gorman
An external fragmentation event was previously described as When the page allocator fragments memory, it records the event using the mm_page_alloc_extfrag event. If the fallback_order is smaller than a pageblock order (order-9 on 64-bit x86) then it's considered an event that will