Re: [PATCH 3/4] perf/x86/cqm: One check and another variable less in intel_mbm_init()

2016-09-08 Thread Peter Zijlstra
On Sun, Sep 04, 2016 at 07:58:32PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 4 Sep 2016 19:06:33 +0200 > > 1. Adjust a jump target to eliminate an extra check at the end. > > 2. Move a jump label according to the current Linux coding

Re: [PATCH 3/4] perf/x86/cqm: One check and another variable less in intel_mbm_init()

2016-09-08 Thread Peter Zijlstra
On Sun, Sep 04, 2016 at 07:58:32PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 4 Sep 2016 19:06:33 +0200 > > 1. Adjust a jump target to eliminate an extra check at the end. > > 2. Move a jump label according to the current Linux coding style convention. WTF does that

Re: [PATCH 3/4] perf/x86/cqm: One check and another variable less in intel_mbm_init()

2016-09-05 Thread Peter Zijlstra
On Sun, Sep 04, 2016 at 07:58:32PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 4 Sep 2016 19:06:33 +0200 > > 1. Adjust a jump target to eliminate an extra check at the end. > > 2. Move a jump label according to the current Linux coding

Re: [PATCH 3/4] perf/x86/cqm: One check and another variable less in intel_mbm_init()

2016-09-05 Thread Peter Zijlstra
On Sun, Sep 04, 2016 at 07:58:32PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 4 Sep 2016 19:06:33 +0200 > > 1. Adjust a jump target to eliminate an extra check at the end. > > 2. Move a jump label according to the current Linux coding style convention. WTF does that

[PATCH 3/4] perf/x86/cqm: One check and another variable less in intel_mbm_init()

2016-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 4 Sep 2016 19:06:33 +0200 1. Adjust a jump target to eliminate an extra check at the end. 2. Move a jump label according to the current Linux coding style convention. 3. Return only constant values for the success or failure

[PATCH 3/4] perf/x86/cqm: One check and another variable less in intel_mbm_init()

2016-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 4 Sep 2016 19:06:33 +0200 1. Adjust a jump target to eliminate an extra check at the end. 2. Move a jump label according to the current Linux coding style convention. 3. Return only constant values for the success or failure indication. 4. Delete the local