Re: [PATCH 3/4] spi: bcm-qspi: Fix probe regression on iProc platforms

2020-09-10 Thread Florian Fainelli




On 9/10/2020 8:25 AM, Ray Jui wrote:

iProc chips have QSPI controller that does not have the MSPI_REV
offset. Reading from that offset will cause a bus error. Fix it by
having MSPI_REV query disabled in the generic compatible string.

Fixes: 3a01f04d74ef ("spi: bcm-qspi: Handle lack of MSPI_REV offset")
Link: 
https://lore.kernel.org/linux-arm-kernel/20200909211857.4144718-1-f.faine...@gmail.com/T/#u
Signed-off-by: Ray Jui 


Acked-by: Florian Fainelli 
--
Florian


[PATCH 3/4] spi: bcm-qspi: Fix probe regression on iProc platforms

2020-09-10 Thread Ray Jui
iProc chips have QSPI controller that does not have the MSPI_REV
offset. Reading from that offset will cause a bus error. Fix it by
having MSPI_REV query disabled in the generic compatible string.

Fixes: 3a01f04d74ef ("spi: bcm-qspi: Handle lack of MSPI_REV offset")
Link: 
https://lore.kernel.org/linux-arm-kernel/20200909211857.4144718-1-f.faine...@gmail.com/T/#u
Signed-off-by: Ray Jui 
---
 drivers/spi/spi-bcm-qspi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c
index c5209b42b0d2..b78d47a4403c 100644
--- a/drivers/spi/spi-bcm-qspi.c
+++ b/drivers/spi/spi-bcm-qspi.c
@@ -1300,7 +1300,7 @@ static const struct of_device_id bcm_qspi_of_match[] = {
},
{
.compatible = "brcm,spi-bcm-qspi",
-   .data = _qspi_rev_data,
+   .data = _qspi_no_rev_data,
},
{
.compatible = "brcm,spi-bcm7216-qspi",
-- 
2.17.1