Re: [PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

2007-07-20 Thread Roland Dreier 
thanks, applied
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

2007-07-20 Thread Hoang-Nam Nguyen 
From: Joachim Fenkes <[EMAIL PROTECTED]>
Date: Thu, 19 Jul 2007 21:13:57 +0200
Subject: [PATCH 3/5] IB/ehca: Make ehca2ib_return_code() non-inline

It's nowhere in the main path and making it non-inline saves ~1.5K of code.

Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]>
---
 drivers/infiniband/hw/ehca/ehca_main.c  |   17 +
 drivers/infiniband/hw/ehca/ehca_tools.h |   19 +--
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/infiniband/hw/ehca/ehca_main.c 
b/drivers/infiniband/hw/ehca/ehca_main.c
index 34661c3..3bd7afb 100644
--- a/drivers/infiniband/hw/ehca/ehca_main.c
+++ b/drivers/infiniband/hw/ehca/ehca_main.c
@@ -130,6 +130,23 @@ void ehca_free_fw_ctrlblock(void *ptr)
 }
 #endif
 
+int ehca2ib_return_code(u64 ehca_rc)
+{
+   switch (ehca_rc) {
+   case H_SUCCESS:
+   return 0;
+   case H_RESOURCE: /* Resource in use */
+   case H_BUSY:
+   return -EBUSY;
+   case H_NOT_ENOUGH_RESOURCES: /* insufficient resources */
+   case H_CONSTRAINED:  /* resource constraint */
+   case H_NO_MEM:
+   return -ENOMEM;
+   default:
+   return -EINVAL;
+   }
+}
+
 static int ehca_create_slab_caches(void)
 {
int ret;
diff --git a/drivers/infiniband/hw/ehca/ehca_tools.h 
b/drivers/infiniband/hw/ehca/ehca_tools.h
index 678b813..57c77a7 100644
--- a/drivers/infiniband/hw/ehca/ehca_tools.h
+++ b/drivers/infiniband/hw/ehca/ehca_tools.h
@@ -154,24 +154,7 @@ extern int ehca_debug_level;
 #define EHCA_BMASK_GET(mask, value) \
(EHCA_BMASK_MASK(mask) & (((u64)(value)) >> EHCA_BMASK_SHIFTPOS(mask)))
 
-
 /* Converts ehca to ib return code */
-static inline int ehca2ib_return_code(u64 ehca_rc)
-{
-   switch (ehca_rc) {
-   case H_SUCCESS:
-   return 0;
-   case H_RESOURCE: /* Resource in use */
-   case H_BUSY:
-   return -EBUSY;
-   case H_NOT_ENOUGH_RESOURCES: /* insufficient resources */
-   case H_CONSTRAINED:  /* resource constraint */
-   case H_NO_MEM:
-   return -ENOMEM;
-   default:
-   return -EINVAL;
-   }
-}
-
+int ehca2ib_return_code(u64 ehca_rc);
 
 #endif /* EHCA_TOOLS_H */
-- 
1.5.2


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

2007-07-20 Thread Hoang-Nam Nguyen 
From: Joachim Fenkes [EMAIL PROTECTED]
Date: Thu, 19 Jul 2007 21:13:57 +0200
Subject: [PATCH 3/5] IB/ehca: Make ehca2ib_return_code() non-inline

It's nowhere in the main path and making it non-inline saves ~1.5K of code.

Signed-off-by: Joachim Fenkes [EMAIL PROTECTED]
---
 drivers/infiniband/hw/ehca/ehca_main.c  |   17 +
 drivers/infiniband/hw/ehca/ehca_tools.h |   19 +--
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/infiniband/hw/ehca/ehca_main.c 
b/drivers/infiniband/hw/ehca/ehca_main.c
index 34661c3..3bd7afb 100644
--- a/drivers/infiniband/hw/ehca/ehca_main.c
+++ b/drivers/infiniband/hw/ehca/ehca_main.c
@@ -130,6 +130,23 @@ void ehca_free_fw_ctrlblock(void *ptr)
 }
 #endif
 
+int ehca2ib_return_code(u64 ehca_rc)
+{
+   switch (ehca_rc) {
+   case H_SUCCESS:
+   return 0;
+   case H_RESOURCE: /* Resource in use */
+   case H_BUSY:
+   return -EBUSY;
+   case H_NOT_ENOUGH_RESOURCES: /* insufficient resources */
+   case H_CONSTRAINED:  /* resource constraint */
+   case H_NO_MEM:
+   return -ENOMEM;
+   default:
+   return -EINVAL;
+   }
+}
+
 static int ehca_create_slab_caches(void)
 {
int ret;
diff --git a/drivers/infiniband/hw/ehca/ehca_tools.h 
b/drivers/infiniband/hw/ehca/ehca_tools.h
index 678b813..57c77a7 100644
--- a/drivers/infiniband/hw/ehca/ehca_tools.h
+++ b/drivers/infiniband/hw/ehca/ehca_tools.h
@@ -154,24 +154,7 @@ extern int ehca_debug_level;
 #define EHCA_BMASK_GET(mask, value) \
(EHCA_BMASK_MASK(mask)  (((u64)(value))  EHCA_BMASK_SHIFTPOS(mask)))
 
-
 /* Converts ehca to ib return code */
-static inline int ehca2ib_return_code(u64 ehca_rc)
-{
-   switch (ehca_rc) {
-   case H_SUCCESS:
-   return 0;
-   case H_RESOURCE: /* Resource in use */
-   case H_BUSY:
-   return -EBUSY;
-   case H_NOT_ENOUGH_RESOURCES: /* insufficient resources */
-   case H_CONSTRAINED:  /* resource constraint */
-   case H_NO_MEM:
-   return -ENOMEM;
-   default:
-   return -EINVAL;
-   }
-}
-
+int ehca2ib_return_code(u64 ehca_rc);
 
 #endif /* EHCA_TOOLS_H */
-- 
1.5.2


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/5] ehca: Make ehca2ib_return_code() non-inline

2007-07-20 Thread Roland Dreier 
thanks, applied
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/