[PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-27 Thread Jiri Olsa
Once the breakpoint was succesfully modified, the attr->disabled value is in bp->attr.disabled. So there's no reason to set it again, removing that. Acked-by: Oleg Nesterov Acked-by: Frederic Weisbecker Link: http://lkml.kernel.org/n/tip-v5oaellzsmyszv3rfucux...@git.kernel.org Signed-off-by:

[PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-27 Thread Jiri Olsa
Once the breakpoint was succesfully modified, the attr->disabled value is in bp->attr.disabled. So there's no reason to set it again, removing that. Acked-by: Oleg Nesterov Acked-by: Frederic Weisbecker Link: http://lkml.kernel.org/n/tip-v5oaellzsmyszv3rfucux...@git.kernel.org Signed-off-by:

Re: [PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-17 Thread Frederic Weisbecker
On Fri, Aug 10, 2018 at 12:47:28PM +0200, Jiri Olsa wrote: > Once the breakpoint was succesfully modified, the attr->disabled > value is in bp->attr.disabled. So there's no reason to set it > again, removing that. > > Acked-by: Oleg Nesterov > Link:

Re: [PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-17 Thread Frederic Weisbecker
On Fri, Aug 10, 2018 at 12:47:28PM +0200, Jiri Olsa wrote: > Once the breakpoint was succesfully modified, the attr->disabled > value is in bp->attr.disabled. So there's no reason to set it > again, removing that. > > Acked-by: Oleg Nesterov > Link:

[PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-10 Thread Jiri Olsa
Once the breakpoint was succesfully modified, the attr->disabled value is in bp->attr.disabled. So there's no reason to set it again, removing that. Acked-by: Oleg Nesterov Link: http://lkml.kernel.org/n/tip-v5oaellzsmyszv3rfucux...@git.kernel.org Signed-off-by: Jiri Olsa ---

[PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-10 Thread Jiri Olsa
Once the breakpoint was succesfully modified, the attr->disabled value is in bp->attr.disabled. So there's no reason to set it again, removing that. Acked-by: Oleg Nesterov Link: http://lkml.kernel.org/n/tip-v5oaellzsmyszv3rfucux...@git.kernel.org Signed-off-by: Jiri Olsa ---

Re: [PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-09 Thread Oleg Nesterov
On 08/09, Jiri Olsa wrote: > > @@ -526,10 +526,9 @@ int modify_user_hw_breakpoint(struct perf_event *bp, > struct perf_event_attr *att > if (err) > return err; > > - if (!attr->disabled) { > + if (!attr->disabled) > perf_event_enable(bp); > -

Re: [PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-09 Thread Oleg Nesterov
On 08/09, Jiri Olsa wrote: > > @@ -526,10 +526,9 @@ int modify_user_hw_breakpoint(struct perf_event *bp, > struct perf_event_attr *att > if (err) > return err; > > - if (!attr->disabled) { > + if (!attr->disabled) > perf_event_enable(bp); > -

[PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-09 Thread Jiri Olsa
Once the breakpoint was succesfully modified, the attr->disabled value is in bp->attr.disabled. So there's no reason to set it again, removing that. Link: http://lkml.kernel.org/n/tip-v5oaellzsmyszv3rfucux...@git.kernel.org Signed-off-by: Jiri Olsa --- kernel/events/hw_breakpoint.c | 5 ++--- 1

[PATCH 3/5] perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0

2018-08-09 Thread Jiri Olsa
Once the breakpoint was succesfully modified, the attr->disabled value is in bp->attr.disabled. So there's no reason to set it again, removing that. Link: http://lkml.kernel.org/n/tip-v5oaellzsmyszv3rfucux...@git.kernel.org Signed-off-by: Jiri Olsa --- kernel/events/hw_breakpoint.c | 5 ++--- 1