Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Peter Zijlstra
On Wed, Nov 01, 2017 at 12:20:52PM -0500, Eric W. Biederman wrote: > Well the way I was hearing the conversation was that there was a patch > that fixed a real bug, but it was wrong because checkpatch complained > about it. > > So I don't even know if the warning is a problem. But blocking bug >

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Eric W. Biederman
Joe Perches writes: > On Wed, 2017-11-01 at 06:08 -0500, Eric W. Biederman wrote: >> I won't listen to checkpatch when it is wrong. > > Always a good idea. > > btw: what is checkpatch wrong about this time? Well the way I was hearing the conversation was that there was a patch that fixed a real

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Joe Perches
On Wed, 2017-11-01 at 06:08 -0500, Eric W. Biederman wrote: > I won't listen to checkpatch when it is wrong. Always a good idea. btw: what is checkpatch wrong about this time?

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Christian Brauner
On Wed, Nov 01, 2017 at 02:05:39PM +0100, Peter Zijlstra wrote: > On Wed, Nov 01, 2017 at 06:08:35AM -0500, Eric W. Biederman wrote: > > Nikolay Borisov writes: > > > > > On 1.11.2017 01:48, Eric W. Biederman wrote: > > >> > > >> This is important so reading /proc//{uid_map,gid_map,projid_map}

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Christian Brauner
On Wed, Nov 01, 2017 at 03:16:54PM +0100, Peter Zijlstra wrote: > On Wed, Nov 01, 2017 at 03:01:45PM +0100, Christian Brauner wrote: > > Tbf, this isn't solely Eric's fault. I'm to blame here too since I didn't > > document the already existing smb_rmb()s and the new one I introduced when > > writi

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Peter Zijlstra
On Wed, Nov 01, 2017 at 03:01:45PM +0100, Christian Brauner wrote: > Tbf, this isn't solely Eric's fault. I'm to blame here too since I didn't > document the already existing smb_rmb()s and the new one I introduced when > writing the patches. I didn't know that there was a hard-set requirement to >

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Christian Brauner
On Wed, Nov 01, 2017 at 02:05:39PM +0100, Peter Zijlstra wrote: > On Wed, Nov 01, 2017 at 06:08:35AM -0500, Eric W. Biederman wrote: > > Nikolay Borisov writes: > > > > > On 1.11.2017 01:48, Eric W. Biederman wrote: > > >> > > >> This is important so reading /proc//{uid_map,gid_map,projid_map}

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Peter Zijlstra
On Wed, Nov 01, 2017 at 06:08:35AM -0500, Eric W. Biederman wrote: > Nikolay Borisov writes: > > > On 1.11.2017 01:48, Eric W. Biederman wrote: > >> > >> This is important so reading /proc//{uid_map,gid_map,projid_map} while > >> the map is being written does not do strange things. > >> > >> S

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Nikolay Borisov
[CCing some memory-barriers people + checkpatch maintainers] On 1.11.2017 13:08, Eric W. Biederman wrote: > Nikolay Borisov writes: > >> On 1.11.2017 01:48, Eric W. Biederman wrote: >>> >>> This is important so reading /proc//{uid_map,gid_map,projid_map} while >>> the map is being written does

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Eric W. Biederman
Nikolay Borisov writes: > On 1.11.2017 01:48, Eric W. Biederman wrote: >> >> This is important so reading /proc//{uid_map,gid_map,projid_map} while >> the map is being written does not do strange things. >> >> Signed-off-by: "Eric W. Biederman" >> --- >> kernel/user_namespace.c | 6 -- >>

Re: [PATCH 3/5] userns: Don't read extents twice in m_start

2017-11-01 Thread Nikolay Borisov
On 1.11.2017 01:48, Eric W. Biederman wrote: > > This is important so reading /proc//{uid_map,gid_map,projid_map} while > the map is being written does not do strange things. > > Signed-off-by: "Eric W. Biederman" > --- > kernel/user_namespace.c | 6 -- > 1 file changed, 4 insertions(+),

[PATCH 3/5] userns: Don't read extents twice in m_start

2017-10-31 Thread Eric W. Biederman
This is important so reading /proc//{uid_map,gid_map,projid_map} while the map is being written does not do strange things. Signed-off-by: "Eric W. Biederman" --- kernel/user_namespace.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/user_namespace.c b/kernel/u