Re: [PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Marcel Holtmann 
Hi Gigi,

> Add minimal device tree support to the btwilink driver that is used
> for binding bluetooth with the ti-st shared transport driver.
> 
> Signed-off-by: Eyal Reizer 
> Signed-off-by: bvijay 
> Signed-off-by: Gigi Joseph 
> ---
> drivers/bluetooth/btwilink.c | 11 +++
> 1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
> index 55c135b..95adec3 100644
> --- a/drivers/bluetooth/btwilink.c
> +++ b/drivers/bluetooth/btwilink.c
> @@ -30,6 +30,7 @@
> 
> #include 
> #include 
> +#include 
> 
> /* Bluetooth Driver Version */
> #define VERSION   "1.0"
> @@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct 
> sk_buff *skb)
>   return 0;
> }
> 
> +static const struct of_device_id btwilink_of_match[] = {
> +{
> + .compatible = "btwilink",
> + },
> + {}
> +};

this formatting is bogus. Please construct it similar to what other drivers are 
doing.

static const struct .. = {
{ .compatible = ".." },

{ } /* Terminating entry */
};

And add an extra empty line before MODULE_DEVICE_TABLE.

> +MODULE_DEVICE_TABLE(of, btwilink_of_match);
> +
> static int bt_ti_probe(struct platform_device *pdev)
> {
>   static struct ti_st *hst;
> @@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
>   .remove = bt_ti_remove,
>   .driver = {
>   .name = "btwilink",
> + .owner = THIS_MODULE,
> + .of_match_table = of_match_ptr(btwilink_of_match),
>   },
> };

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Varka Bhadram 
Hi,

On Fri, Jan 9, 2015 at 9:17 AM, Gigi Joseph  wrote:
> Add minimal device tree support to the btwilink driver that is used
> for binding bluetooth with the ti-st shared transport driver.
>
> Signed-off-by: Eyal Reizer 
> Signed-off-by: bvijay 
> Signed-off-by: Gigi Joseph 
> ---
>  drivers/bluetooth/btwilink.c | 11 +++
>  1 file changed, 11 insertions(+)
>
> diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
> index 55c135b..95adec3 100644
> --- a/drivers/bluetooth/btwilink.c
> +++ b/drivers/bluetooth/btwilink.c
> @@ -30,6 +30,7 @@
>
>  #include 
>  #include 
> +#include 
>
>  /* Bluetooth Driver Version */
>  #define VERSION   "1.0"
> @@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct 
> sk_buff *skb)
> return 0;
>  }
>
> +static const struct of_device_id btwilink_of_match[] = {
> +{
> +   .compatible = "btwilink",
compatible property include the manufacturer name also...
compatible=","
> +   },
> +   {}
> +};
> +MODULE_DEVICE_TABLE(of, btwilink_of_match);
> +
>  static int bt_ti_probe(struct platform_device *pdev)
>  {
> static struct ti_st *hst;
> @@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
> .remove = bt_ti_remove,
> .driver = {
> .name = "btwilink",
> +   .owner = THIS_MODULE,
No need to update this field. It will be updated by driver core.
> +   .of_match_table = of_match_ptr(btwilink_of_match),
> },
>  };
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks and Regards,
Varka Bhadram.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Gigi Joseph 
Add minimal device tree support to the btwilink driver that is used
for binding bluetooth with the ti-st shared transport driver.

Signed-off-by: Eyal Reizer 
Signed-off-by: bvijay 
Signed-off-by: Gigi Joseph 
---
 drivers/bluetooth/btwilink.c | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
index 55c135b..95adec3 100644
--- a/drivers/bluetooth/btwilink.c
+++ b/drivers/bluetooth/btwilink.c
@@ -30,6 +30,7 @@
 
 #include 
 #include 
+#include 
 
 /* Bluetooth Driver Version */
 #define VERSION   "1.0"
@@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct 
sk_buff *skb)
return 0;
 }
 
+static const struct of_device_id btwilink_of_match[] = {
+{
+   .compatible = "btwilink",
+   },
+   {}
+};
+MODULE_DEVICE_TABLE(of, btwilink_of_match);
+
 static int bt_ti_probe(struct platform_device *pdev)
 {
static struct ti_st *hst;
@@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
.remove = bt_ti_remove,
.driver = {
.name = "btwilink",
+   .owner = THIS_MODULE,
+   .of_match_table = of_match_ptr(btwilink_of_match),
},
 };
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Gigi Joseph 
Add minimal device tree support to the btwilink driver that is used
for binding bluetooth with the ti-st shared transport driver.

Signed-off-by: Eyal Reizer ey...@ti.com
Signed-off-by: bvijay bvi...@ti.com
Signed-off-by: Gigi Joseph gigi.jos...@ti.com
---
 drivers/bluetooth/btwilink.c | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
index 55c135b..95adec3 100644
--- a/drivers/bluetooth/btwilink.c
+++ b/drivers/bluetooth/btwilink.c
@@ -30,6 +30,7 @@
 
 #include linux/ti_wilink_st.h
 #include linux/module.h
+#include linux/of.h
 
 /* Bluetooth Driver Version */
 #define VERSION   1.0
@@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct 
sk_buff *skb)
return 0;
 }
 
+static const struct of_device_id btwilink_of_match[] = {
+{
+   .compatible = btwilink,
+   },
+   {}
+};
+MODULE_DEVICE_TABLE(of, btwilink_of_match);
+
 static int bt_ti_probe(struct platform_device *pdev)
 {
static struct ti_st *hst;
@@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
.remove = bt_ti_remove,
.driver = {
.name = btwilink,
+   .owner = THIS_MODULE,
+   .of_match_table = of_match_ptr(btwilink_of_match),
},
 };
 
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Varka Bhadram 
Hi,

On Fri, Jan 9, 2015 at 9:17 AM, Gigi Joseph gigi.jos...@gmail.com wrote:
 Add minimal device tree support to the btwilink driver that is used
 for binding bluetooth with the ti-st shared transport driver.

 Signed-off-by: Eyal Reizer ey...@ti.com
 Signed-off-by: bvijay bvi...@ti.com
 Signed-off-by: Gigi Joseph gigi.jos...@ti.com
 ---
  drivers/bluetooth/btwilink.c | 11 +++
  1 file changed, 11 insertions(+)

 diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
 index 55c135b..95adec3 100644
 --- a/drivers/bluetooth/btwilink.c
 +++ b/drivers/bluetooth/btwilink.c
 @@ -30,6 +30,7 @@

  #include linux/ti_wilink_st.h
  #include linux/module.h
 +#include linux/of.h

  /* Bluetooth Driver Version */
  #define VERSION   1.0
 @@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct 
 sk_buff *skb)
 return 0;
  }

 +static const struct of_device_id btwilink_of_match[] = {
 +{
 +   .compatible = btwilink,
compatible property include the manufacturer name also...
compatible=manufacturer,model
 +   },
 +   {}
 +};
 +MODULE_DEVICE_TABLE(of, btwilink_of_match);
 +
  static int bt_ti_probe(struct platform_device *pdev)
  {
 static struct ti_st *hst;
 @@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
 .remove = bt_ti_remove,
 .driver = {
 .name = btwilink,
 +   .owner = THIS_MODULE,
No need to update this field. It will be updated by driver core.
 +   .of_match_table = of_match_ptr(btwilink_of_match),
 },
  };

 --
 1.9.1

 --
 To unsubscribe from this list: send the line unsubscribe devicetree in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks and Regards,
Varka Bhadram.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/6] btwilink: add minimal device tree support

2015-01-08 Thread Marcel Holtmann 
Hi Gigi,

 Add minimal device tree support to the btwilink driver that is used
 for binding bluetooth with the ti-st shared transport driver.
 
 Signed-off-by: Eyal Reizer ey...@ti.com
 Signed-off-by: bvijay bvi...@ti.com
 Signed-off-by: Gigi Joseph gigi.jos...@ti.com
 ---
 drivers/bluetooth/btwilink.c | 11 +++
 1 file changed, 11 insertions(+)
 
 diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
 index 55c135b..95adec3 100644
 --- a/drivers/bluetooth/btwilink.c
 +++ b/drivers/bluetooth/btwilink.c
 @@ -30,6 +30,7 @@
 
 #include linux/ti_wilink_st.h
 #include linux/module.h
 +#include linux/of.h
 
 /* Bluetooth Driver Version */
 #define VERSION   1.0
 @@ -286,6 +287,14 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct 
 sk_buff *skb)
   return 0;
 }
 
 +static const struct of_device_id btwilink_of_match[] = {
 +{
 + .compatible = btwilink,
 + },
 + {}
 +};

this formatting is bogus. Please construct it similar to what other drivers are 
doing.

static const struct .. = {
{ .compatible = .. },

{ } /* Terminating entry */
};

And add an extra empty line before MODULE_DEVICE_TABLE.

 +MODULE_DEVICE_TABLE(of, btwilink_of_match);
 +
 static int bt_ti_probe(struct platform_device *pdev)
 {
   static struct ti_st *hst;
 @@ -349,6 +358,8 @@ static struct platform_driver btwilink_driver = {
   .remove = bt_ti_remove,
   .driver = {
   .name = btwilink,
 + .owner = THIS_MODULE,
 + .of_match_table = of_match_ptr(btwilink_of_match),
   },
 };

Regards

Marcel

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/