Re: [PATCH 3/6] cifs: quit playing games with draining iovecs

2016-04-19 Thread Al Viro
On Tue, Apr 19, 2016 at 01:53:17PM -0400, Jeff Layton wrote: > What's the advantage of using iov_iter_bvec over iov_iter_kvec ? No need to screw with kmap() in the caller; moreover, when it comes to actual copying it gets away with kmap_atomic() just around the memcpy(), which is considerably

Re: [PATCH 3/6] cifs: quit playing games with draining iovecs

2016-04-19 Thread Al Viro
On Tue, Apr 19, 2016 at 01:53:17PM -0400, Jeff Layton wrote: > What's the advantage of using iov_iter_bvec over iov_iter_kvec ? No need to screw with kmap() in the caller; moreover, when it comes to actual copying it gets away with kmap_atomic() just around the memcpy(), which is considerably

Re: [PATCH 3/6] cifs: quit playing games with draining iovecs

2016-04-19 Thread Jeff Layton
On Sat, 2016-04-09 at 21:51 +0100, Al Viro wrote: > ... and use ITER_BVEC for the page part of request to send > > Signed-off-by: Al Viro > --- >  fs/cifs/cifsproto.h |   2 - >  fs/cifs/transport.c | 141 +++--- > -- >  2 files

Re: [PATCH 3/6] cifs: quit playing games with draining iovecs

2016-04-19 Thread Jeff Layton
On Sat, 2016-04-09 at 21:51 +0100, Al Viro wrote: > ... and use ITER_BVEC for the page part of request to send > > Signed-off-by: Al Viro > --- >  fs/cifs/cifsproto.h |   2 - >  fs/cifs/transport.c | 141 +++--- > -- >  2 files changed, 41

[PATCH 3/6] cifs: quit playing games with draining iovecs

2016-04-09 Thread Al Viro
... and use ITER_BVEC for the page part of request to send Signed-off-by: Al Viro --- fs/cifs/cifsproto.h | 2 - fs/cifs/transport.c | 141 +++- 2 files changed, 41 insertions(+), 102 deletions(-) diff --git

[PATCH 3/6] cifs: quit playing games with draining iovecs

2016-04-09 Thread Al Viro
... and use ITER_BVEC for the page part of request to send Signed-off-by: Al Viro --- fs/cifs/cifsproto.h | 2 - fs/cifs/transport.c | 141 +++- 2 files changed, 41 insertions(+), 102 deletions(-) diff --git a/fs/cifs/cifsproto.h