Re: [f2fs-dev] [PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-02-22 Thread Jaegeuk Kim
On 02/23, Chao Yu wrote: > On 2017/2/23 5:55, Jaegeuk Kim wrote: > > On 02/22, Chao Yu wrote: > >> On 2017/1/13 6:44, Jaegeuk Kim wrote: > >>> We don't need to do multiple checkpoints, since we don't actually wait for > >>> completion of discard commands during checkpoint. > >>> Instead, we still

Re: [f2fs-dev] [PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-02-22 Thread Jaegeuk Kim
On 02/23, Chao Yu wrote: > On 2017/2/23 5:55, Jaegeuk Kim wrote: > > On 02/22, Chao Yu wrote: > >> On 2017/1/13 6:44, Jaegeuk Kim wrote: > >>> We don't need to do multiple checkpoints, since we don't actually wait for > >>> completion of discard commands during checkpoint. > >>> Instead, we still

Re: [f2fs-dev] [PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-02-22 Thread Chao Yu
On 2017/2/23 5:55, Jaegeuk Kim wrote: > On 02/22, Chao Yu wrote: >> On 2017/1/13 6:44, Jaegeuk Kim wrote: >>> We don't need to do multiple checkpoints, since we don't actually wait for >>> completion of discard commands during checkpoint. >>> Instead, we still need to avoid very big discard

Re: [f2fs-dev] [PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-02-22 Thread Chao Yu
On 2017/2/23 5:55, Jaegeuk Kim wrote: > On 02/22, Chao Yu wrote: >> On 2017/1/13 6:44, Jaegeuk Kim wrote: >>> We don't need to do multiple checkpoints, since we don't actually wait for >>> completion of discard commands during checkpoint. >>> Instead, we still need to avoid very big discard

Re: [f2fs-dev] [PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-02-22 Thread Jaegeuk Kim
On 02/22, Chao Yu wrote: > On 2017/1/13 6:44, Jaegeuk Kim wrote: > > We don't need to do multiple checkpoints, since we don't actually wait for > > completion of discard commands during checkpoint. > > Instead, we still need to avoid very big discard commands, since that large > > discard can

Re: [f2fs-dev] [PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-02-22 Thread Jaegeuk Kim
On 02/22, Chao Yu wrote: > On 2017/1/13 6:44, Jaegeuk Kim wrote: > > We don't need to do multiple checkpoints, since we don't actually wait for > > completion of discard commands during checkpoint. > > Instead, we still need to avoid very big discard commands, since that large > > discard can

Re: [PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-02-22 Thread Chao Yu
On 2017/1/13 6:44, Jaegeuk Kim wrote: > We don't need to do multiple checkpoints, since we don't actually wait for > completion of discard commands during checkpoint. > Instead, we still need to avoid very big discard commands, since that large > discard can interfere block allocation. I hope we

Re: [PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-02-22 Thread Chao Yu
On 2017/1/13 6:44, Jaegeuk Kim wrote: > We don't need to do multiple checkpoints, since we don't actually wait for > completion of discard commands during checkpoint. > Instead, we still need to avoid very big discard commands, since that large > discard can interfere block allocation. I hope we

[PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-01-12 Thread Jaegeuk Kim
We don't need to do multiple checkpoints, since we don't actually wait for completion of discard commands during checkpoint. Instead, we still need to avoid very big discard commands, since that large discard can interfere block allocation. Signed-off-by: Jaegeuk Kim ---

[PATCH 3/6] f2fs: remove batched discard in f2fs_trim_fs

2017-01-12 Thread Jaegeuk Kim
We don't need to do multiple checkpoints, since we don't actually wait for completion of discard commands during checkpoint. Instead, we still need to avoid very big discard commands, since that large discard can interfere block allocation. Signed-off-by: Jaegeuk Kim ---