Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Dan Carpenter
On Thu, Jun 06, 2013 at 02:23:08PM -0700, Joe Perches wrote: > On Fri, 2013-06-07 at 00:11 +0300, Dan Carpenter wrote: > > On Thu, Jun 06, 2013 at 10:53:20AM -0700, Joe Perches wrote: > > > On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: > > > > From: Laura Lawniczak > > > [] > > > >

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Joe Perches
On Fri, 2013-06-07 at 00:11 +0300, Dan Carpenter wrote: > On Thu, Jun 06, 2013 at 10:53:20AM -0700, Joe Perches wrote: > > On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: > > > From: Laura Lawniczak > > [] > > > diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Dan Carpenter
On Thu, Jun 06, 2013 at 06:10:47PM +0200, Johannes Schilling wrote: > @@ -321,7 +320,7 @@ int ENE_Write_Data(struct us_data *us, void *buf, > unsigned int length) > /* > * usb_stor_print_cmd(): > */ > -void usb_stor_print_cmd(struct scsi_cmnd *srb) > +void usb_stor_print_cmd(struct us_data

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Dan Carpenter
On Thu, Jun 06, 2013 at 10:53:20AM -0700, Joe Perches wrote: > On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: > > From: Laura Lawniczak > [] > > diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c > [] > > @@ -19,13 +19,13 @@ int ENE_InitMedia(struct us_data

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Joe Perches
On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: > From: Laura Lawniczak [] > diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c [] > @@ -19,13 +19,13 @@ int ENE_InitMedia(struct us_data *us) [] > - printk(KERN_INFO "MiscReg03 = %x\n", MiscReg03); > +

[PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Johannes Schilling
From: Laura Lawniczak as per suggestion of checkpatch.pl; this resolves warnings like "Prefer netdev_info .. then dev_info .. to printk". Changed signature of function usb_stor_print_cmd in init.c to enable usage of dev_err Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling ---

[PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Johannes Schilling
From: Laura Lawniczak laura.lawnic...@googlemail.com as per suggestion of checkpatch.pl; this resolves warnings like Prefer netdev_info .. then dev_info .. to printk. Changed signature of function usb_stor_print_cmd in init.c to enable usage of dev_err Signed-off-by: Laura Lawniczak

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Joe Perches
On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: From: Laura Lawniczak laura.lawnic...@googlemail.com [] diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c [] @@ -19,13 +19,13 @@ int ENE_InitMedia(struct us_data *us) [] - printk(KERN_INFO MiscReg03 = %x\n,

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Dan Carpenter
On Thu, Jun 06, 2013 at 10:53:20AM -0700, Joe Perches wrote: On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: From: Laura Lawniczak laura.lawnic...@googlemail.com [] diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c [] @@ -19,13 +19,13 @@ int

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Dan Carpenter
On Thu, Jun 06, 2013 at 06:10:47PM +0200, Johannes Schilling wrote: @@ -321,7 +320,7 @@ int ENE_Write_Data(struct us_data *us, void *buf, unsigned int length) /* * usb_stor_print_cmd(): */ -void usb_stor_print_cmd(struct scsi_cmnd *srb) +void usb_stor_print_cmd(struct us_data

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Joe Perches
On Fri, 2013-06-07 at 00:11 +0300, Dan Carpenter wrote: On Thu, Jun 06, 2013 at 10:53:20AM -0700, Joe Perches wrote: On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: From: Laura Lawniczak laura.lawnic...@googlemail.com [] diff --git a/drivers/staging/keucr/init.c

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-06 Thread Dan Carpenter
On Thu, Jun 06, 2013 at 02:23:08PM -0700, Joe Perches wrote: On Fri, 2013-06-07 at 00:11 +0300, Dan Carpenter wrote: On Thu, Jun 06, 2013 at 10:53:20AM -0700, Joe Perches wrote: On Thu, 2013-06-06 at 18:10 +0200, Johannes Schilling wrote: From: Laura Lawniczak

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-05 Thread Dan Carpenter
On Wed, Jun 05, 2013 at 10:50:03AM +0200, Johannes Schilling wrote: > diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c > index a0fdffd..0e8ced1 100644 > --- a/drivers/staging/keucr/init.c > +++ b/drivers/staging/keucr/init.c > @@ -19,13 +19,13 @@ int ENE_InitMedia(struct

[PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-05 Thread Johannes Schilling
as per suggestion of checkpatch.pl; this resolves warnings like "Prefer netdev_info .. then dev_info .. to printk". Signed-off-by: Laura Lawniczak Signed-off-by: Johannes Schilling --- drivers/staging/keucr/init.c | 62 ++

[PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-05 Thread Johannes Schilling
as per suggestion of checkpatch.pl; this resolves warnings like Prefer netdev_info .. then dev_info .. to printk. Signed-off-by: Laura Lawniczak laura.lawnic...@googlemail.com Signed-off-by: Johannes Schilling of82e...@cip.cs.fau.de --- drivers/staging/keucr/init.c | 62

Re: [PATCH 3/6] keucr: migrate printk to dev_dbg/info/warn/err

2013-06-05 Thread Dan Carpenter
On Wed, Jun 05, 2013 at 10:50:03AM +0200, Johannes Schilling wrote: diff --git a/drivers/staging/keucr/init.c b/drivers/staging/keucr/init.c index a0fdffd..0e8ced1 100644 --- a/drivers/staging/keucr/init.c +++ b/drivers/staging/keucr/init.c @@ -19,13 +19,13 @@ int ENE_InitMedia(struct us_data