Re: [PATCH 3/6] staging: sm750fb: Make internal functions static

2015-03-11 Thread Lorenzo Stoakes
On 11 March 2015 at 09:30, Sudip Mukherjee > this is introducing a build warning, better remove this from your patch > and send a separate patch to remove the function as this function is > not used anywhere. Hi Sudip, I didn't realise I'd included the move to static in this patch. In a later

Re: [PATCH 3/6] staging: sm750fb: Make internal functions static

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 01:28:42AM +, Lorenzo Stoakes wrote: > This patch declares externally unavailable functions static. This fixes the > following sparse warnings:- > diff --git a/drivers/staging/sm750fb/sm750_accel.c > b/drivers/staging/sm750fb/sm750_accel.c > index 6521c3b..4aa763b

Re: [PATCH 3/6] staging: sm750fb: Make internal functions static

2015-03-11 Thread Sudip Mukherjee
On Wed, Mar 11, 2015 at 01:28:42AM +, Lorenzo Stoakes wrote: This patch declares externally unavailable functions static. This fixes the following sparse warnings:- snip diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 6521c3b..4aa763b

Re: [PATCH 3/6] staging: sm750fb: Make internal functions static

2015-03-11 Thread Lorenzo Stoakes
On 11 March 2015 at 09:30, Sudip Mukherjee this is introducing a build warning, better remove this from your patch and send a separate patch to remove the function as this function is not used anywhere. Hi Sudip, I didn't realise I'd included the move to static in this patch. In a later patch

[PATCH 3/6] staging: sm750fb: Make internal functions static

2015-03-10 Thread Lorenzo Stoakes
This patch declares externally unavailable functions static. This fixes the following sparse warnings:- drivers/staging/sm750fb/ddk750_swi2c.c:223:6: warning: symbol 'swI2CStart' was not declared. Should it be static? drivers/staging/sm750fb/ddk750_swi2c.c:234:6: warning: symbol 'swI2CStop' was

[PATCH 3/6] staging: sm750fb: Make internal functions static

2015-03-10 Thread Lorenzo Stoakes
This patch declares externally unavailable functions static. This fixes the following sparse warnings:- drivers/staging/sm750fb/ddk750_swi2c.c:223:6: warning: symbol 'swI2CStart' was not declared. Should it be static? drivers/staging/sm750fb/ddk750_swi2c.c:234:6: warning: symbol 'swI2CStop' was