Re: [PATCH 3/6] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()

2018-07-14 Thread Huang, Ying
Daniel Jordan writes: > On Fri, Jul 13, 2018 at 07:36:33AM +0800, Huang, Ying wrote: >> diff --git a/mm/swapfile.c b/mm/swapfile.c >> index 75c84aa763a3..160f78072667 100644 >> --- a/mm/swapfile.c >> +++ b/mm/swapfile.c >> @@ -270,7 +270,10 @@ static inline void cluster_set_null(struct >>

Re: [PATCH 3/6] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()

2018-07-14 Thread Huang, Ying
Daniel Jordan writes: > On Fri, Jul 13, 2018 at 07:36:33AM +0800, Huang, Ying wrote: >> diff --git a/mm/swapfile.c b/mm/swapfile.c >> index 75c84aa763a3..160f78072667 100644 >> --- a/mm/swapfile.c >> +++ b/mm/swapfile.c >> @@ -270,7 +270,10 @@ static inline void cluster_set_null(struct >>

Re: [PATCH 3/6] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()

2018-07-13 Thread Daniel Jordan
On Fri, Jul 13, 2018 at 07:36:33AM +0800, Huang, Ying wrote: > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 75c84aa763a3..160f78072667 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -270,7 +270,10 @@ static inline void cluster_set_null(struct > swap_cluster_info *info) > >

Re: [PATCH 3/6] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()

2018-07-13 Thread Daniel Jordan
On Fri, Jul 13, 2018 at 07:36:33AM +0800, Huang, Ying wrote: > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 75c84aa763a3..160f78072667 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -270,7 +270,10 @@ static inline void cluster_set_null(struct > swap_cluster_info *info) > >

[PATCH 3/6] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()

2018-07-12 Thread Huang, Ying
From: Huang Ying As suggested by Dave, we should unify the code path for normal and huge swap support if possible to avoid duplicated code, bugs, etc. and make it easier to review code. In this patch, the normal/huge code path in swap_page_trans_huge_swapped() is unified, the added and removed

[PATCH 3/6] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()

2018-07-12 Thread Huang, Ying
From: Huang Ying As suggested by Dave, we should unify the code path for normal and huge swap support if possible to avoid duplicated code, bugs, etc. and make it easier to review code. In this patch, the normal/huge code path in swap_page_trans_huge_swapped() is unified, the added and removed