Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 05:12:01PM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 07:51:17PM -0400, Joel Fernandes wrote: > > On Thu, Jun 18, 2020 at 03:19:01PM -0700, Paul E. McKenney wrote: > > > On Thu, Jun 18, 2020 at 04:29:51PM -0400, Joel Fernandes (Google) wrote: > > > > The

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 08:01:38PM -0400, Steven Rostedt wrote: > On Thu, 18 Jun 2020 15:19:01 -0700 > "Paul E. McKenney" wrote: > > > For future reference, the TPS() around strings is not optional. Without > > it, trace messages from crash dumps are garbled, if I remember correctly. > > When

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 05:12:01PM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 07:51:17PM -0400, Joel Fernandes wrote: > > On Thu, Jun 18, 2020 at 03:19:01PM -0700, Paul E. McKenney wrote: > > > On Thu, Jun 18, 2020 at 04:29:51PM -0400, Joel Fernandes (Google) wrote: > > > > The

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Paul E. McKenney
On Thu, Jun 18, 2020 at 07:51:17PM -0400, Joel Fernandes wrote: > On Thu, Jun 18, 2020 at 03:19:01PM -0700, Paul E. McKenney wrote: > > On Thu, Jun 18, 2020 at 04:29:51PM -0400, Joel Fernandes (Google) wrote: > > > The gp_seq value can come from either of rdp, rsp or rnp. > > > > > > Only the rsp

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Steven Rostedt
On Thu, 18 Jun 2020 15:19:01 -0700 "Paul E. McKenney" wrote: > For future reference, the TPS() around strings is not optional. Without > it, trace messages from crash dumps are garbled, if I remember correctly. When you pass in a string like this, only the pointer to the string is saved in the

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Joel Fernandes
On Thu, Jun 18, 2020 at 03:19:01PM -0700, Paul E. McKenney wrote: > On Thu, Jun 18, 2020 at 04:29:51PM -0400, Joel Fernandes (Google) wrote: > > The gp_seq value can come from either of rdp, rsp or rnp. > > > > Only the rsp is the global source of truth (most accurate GP info). The > > rnp can be

Re: [PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Paul E. McKenney
On Thu, Jun 18, 2020 at 04:29:51PM -0400, Joel Fernandes (Google) wrote: > The gp_seq value can come from either of rdp, rsp or rnp. > > Only the rsp is the global source of truth (most accurate GP info). The > rnp can be off by ~1 and the rdp can be off by way more. Add some more > context to

[PATCH 3/7] rcu/trace: Add name of the source for gp_seq

2020-06-18 Thread Joel Fernandes (Google)
The gp_seq value can come from either of rdp, rsp or rnp. Only the rsp is the global source of truth (most accurate GP info). The rnp can be off by ~1 and the rdp can be off by way more. Add some more context to traces to clarify where it comes from. Signed-off-by: Joel Fernandes (Google) ---