Re: [PATCH 3/7 v3] sched: factorize PELT update

2016-09-15 Thread Vincent Guittot
On 15 September 2016 at 15:09, Peter Zijlstra wrote: > On Mon, Sep 12, 2016 at 09:47:48AM +0200, Vincent Guittot wrote: >> @@ -3690,7 +3658,7 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity >> *curr, int queued) >> /* >>* Ensure that runnable average

Re: [PATCH 3/7 v3] sched: factorize PELT update

2016-09-15 Thread Vincent Guittot
On 15 September 2016 at 15:09, Peter Zijlstra wrote: > On Mon, Sep 12, 2016 at 09:47:48AM +0200, Vincent Guittot wrote: >> @@ -3690,7 +3658,7 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity >> *curr, int queued) >> /* >>* Ensure that runnable average is periodically

Re: [PATCH 3/7 v3] sched: factorize PELT update

2016-09-15 Thread Peter Zijlstra
On Mon, Sep 12, 2016 at 09:47:48AM +0200, Vincent Guittot wrote: > @@ -3690,7 +3658,7 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity > *curr, int queued) > /* >* Ensure that runnable average is periodically updated. >*/ > - update_load_avg(curr, 1); > +

Re: [PATCH 3/7 v3] sched: factorize PELT update

2016-09-15 Thread Peter Zijlstra
On Mon, Sep 12, 2016 at 09:47:48AM +0200, Vincent Guittot wrote: > @@ -3690,7 +3658,7 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity > *curr, int queued) > /* >* Ensure that runnable average is periodically updated. >*/ > - update_load_avg(curr, 1); > +

[PATCH 3/7 v3] sched: factorize PELT update

2016-09-12 Thread Vincent Guittot
Every time, we modify load/utilization of sched_entity, we start to sync it with its cfs_rq. This update is done is different ways: -when attaching/detaching a sched_entity, we update cfs_rq and then we sync the entity with the cfs_rq. -when enqueueing/dequeuing the sched_entity, we update both

[PATCH 3/7 v3] sched: factorize PELT update

2016-09-12 Thread Vincent Guittot
Every time, we modify load/utilization of sched_entity, we start to sync it with its cfs_rq. This update is done is different ways: -when attaching/detaching a sched_entity, we update cfs_rq and then we sync the entity with the cfs_rq. -when enqueueing/dequeuing the sched_entity, we update both