Re: [PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-02-08 Thread Valentin Schneider
On 08/02/21 16:29, Vincent Guittot wrote: > On Fri, 5 Feb 2021 at 21:07, Valentin Schneider > wrote: >> >> Perhaps I can still keep 5/8 with something like >> >> if (!rq->misfit_task_load) >> return false; >> >> do { >> if (capacity_greater(group->sgc->max_capacity,

Re: [PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-02-08 Thread Vincent Guittot
On Fri, 5 Feb 2021 at 21:07, Valentin Schneider wrote: > > On 05/02/21 18:17, Vincent Guittot wrote: > > On Fri, 5 Feb 2021 at 18:00, Valentin Schneider > >> >> @@ -8253,7 +8260,7 @@ check_cpu_capacity(struct rq *rq, struct > >> >> sched_domain *sd) > >> >> static inline int

Re: [PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-02-05 Thread Vincent Guittot
On Thu, 28 Jan 2021 at 19:32, Valentin Schneider wrote: > > During load-balance, groups classified as group_misfit_task are filtered > out if they do not pass > > group_smaller_max_cpu_capacity(, ); group_smaller_max_cpu_capacity and group_smaller_max_cpu_capacity are removed in the next

Re: [PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-02-05 Thread Valentin Schneider
On 05/02/21 18:17, Vincent Guittot wrote: > On Fri, 5 Feb 2021 at 18:00, Valentin Schneider >> >> @@ -8253,7 +8260,7 @@ check_cpu_capacity(struct rq *rq, struct >> >> sched_domain *sd) >> >> static inline int check_misfit_status(struct rq *rq, struct sched_domain >> >> *sd) >> >> { >> >>

Re: [PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-02-05 Thread Valentin Schneider
On 05/02/21 15:31, Vincent Guittot wrote: > On Thu, 28 Jan 2021 at 19:32, Valentin Schneider > wrote: >> >> During load-balance, groups classified as group_misfit_task are filtered >> out if they do not pass >> >> group_smaller_max_cpu_capacity(, ); > > group_smaller_max_cpu_capacity and

Re: [PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-02-05 Thread Vincent Guittot
On Fri, 5 Feb 2021 at 18:00, Valentin Schneider wrote: > > On 05/02/21 15:31, Vincent Guittot wrote: > > On Thu, 28 Jan 2021 at 19:32, Valentin Schneider > > wrote: > >> > >> During load-balance, groups classified as group_misfit_task are filtered > >> out if they do not pass > >> > >>

Re: [PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-02-03 Thread Valentin Schneider
On 03/02/21 15:15, Qais Yousef wrote: > On 01/28/21 18:31, Valentin Schneider wrote: >> @@ -113,6 +113,13 @@ int __weak arch_asym_cpu_priority(int cpu) >> */ >> #define fits_capacity(cap, max) ((cap) * 1280 < (max) * 1024) >> >> +/* >> + * The margin used when comparing CPU capacities. >>

Re: [PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-02-03 Thread Qais Yousef
On 01/28/21 18:31, Valentin Schneider wrote: > During load-balance, groups classified as group_misfit_task are filtered > out if they do not pass > > group_smaller_max_cpu_capacity(, ); > > which itself employs fits_capacity() to compare the sgc->max_capacity of > both groups. > > Due to the

[PATCH 3/8] sched/fair: Tweak misfit-related capacity checks

2021-01-28 Thread Valentin Schneider
During load-balance, groups classified as group_misfit_task are filtered out if they do not pass group_smaller_max_cpu_capacity(, ); which itself employs fits_capacity() to compare the sgc->max_capacity of both groups. Due to the underlying margin, fits_capacity(X, 1024) will return false for